[analyzer] Fix StreamErrorState hash bug

[steakhal]

Summary

The Profile function was incorrectly implemented.
The StreamErrorState has an implicit bool conversion operator, which
will result in a different hash than faithfully hashing the raw value of
the enum.

I don't have a test for it, since it seems difficult to find one.
Even if we would have one, any change in the hashing algorithm would
have a chance of breaking it, so I don't think it would justify the
effort.

Depends on D127836, which uncovered this issue by marking the related
Profile function dead.

[martong]

Nice catch! LGTM

[steakhal]

This change introduces a single new report:

This makes me believe that this bug was not that important after all.

clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

struct StreamState {
   }
   static StreamState getOpenFailed(const FnDescription *L) {
     return StreamState{L, OpenFailed, {}, false};
   }
 
   void Profile(llvm::FoldingSetNodeID &ID) const {
     ID.AddPointer(LastOperation);
     ID.AddInteger(State);
-    ID.AddInteger(ErrorState);
+    ErrorState.Profile(ID);
     ID.AddBoolean(FilePositionIndeterminate);
   }
 };
 
 } // namespace
 
 //===----------------------------------------------------------------------===//
 // StreamChecker class and utility functions.