[analyzer][NFC] Remove dead field of UnixAPICheckers

[steakhal]

Summary

Initially, I thought there is some fundamental bug here by not using the
bool fields, but it turns out D55425 split this checker into two
separate ones; making these fields dead.

Depends on D127836, which uncovered this issue.

[martong]

Umm, why this can't be part of D127836 ?

[steakhal]

In D127838#3584911, @martong wrote:

Umm, why this can't be part of D127836 ?

It can be, but I wanted to still do this separately. The reasoning in the summary should nominate this to a separate discussion.
Just consider if it was a real catch. I would definitely not wanted it to be part of that generic refactor change.
In the end, it turned out to be not the case, but I wanted to be explicit about this.

That being said, I'd insist.

[martong]

Ok. LGTM

clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp

 
 namespace {
 
 class UnixAPIMisuseChecker : public Checker< check::PreStmt<CallExpr> > {
   mutable std::unique_ptr<BugType> BT_open, BT_pthreadOnce;
   mutable Optional<uint64_t> Val_O_CREAT;
 
 public:
-  bool CheckMisuse = false, CheckPortability = false;
-
   void checkPreStmt(const CallExpr *CE, CheckerContext &C) const;
 
   void CheckOpen(CheckerContext &C, const CallExpr *CE) const;
   void CheckOpenAt(CheckerContext &C, const CallExpr *CE) const;
   void CheckPthreadOnce(CheckerContext &C, const CallExpr *CE) const;
 
   void CheckOpenVariant(CheckerContext &C,
                         const CallExpr *CE, OpenVariant Variant) const;

 // Registration.
 //===----------------------------------------------------------------------===//
 
 #define REGISTER_CHECKER(CHECKERNAME)                                          \
   void ento::register##CHECKERNAME(CheckerManager &mgr) {                      \
     mgr.registerChecker<CHECKERNAME>();                                        \
   }                                                                            \
                                                                                \
-  bool ento::shouldRegister##CHECKERNAME(const CheckerManager &mgr) {              \
+  bool ento::shouldRegister##CHECKERNAME(const CheckerManager &mgr) {          \
     return true;                                                               \
   }
 
 REGISTER_CHECKER(UnixAPIMisuseChecker)
 REGISTER_CHECKER(UnixAPIPortabilityChecker)