This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Split unix.API up to UnixAPIMisuseChecker and UnixAPIPortabilityChecker
ClosedPublic

Authored by Szelethus on Dec 7 2018, 3:42 AM.

Details

Summary

The actual implementation of unix.API features a dual-checker: two checkers in one, even though they don't even interact at all. Split them up, as this is a problem for establishing dependencies.

I added no new code at all, just merely moved it around.

Since the plist files change (and that's a benefit!) this patch isn't NFC.

Diff Detail

Repository
rL LLVM

Event Timeline

Szelethus created this revision.Dec 7 2018, 3:42 AM
Szelethus edited the summary of this revision. (Show Details)Dec 7 2018, 3:42 AM
NoQ accepted this revision.Dec 7 2018, 2:09 PM

Nice!

test/Analysis/Inputs/expected-plists/unix-fns.c.plist
3018 ↗(On Diff #177168)

Does this actually work?

This revision is now accepted and ready to land.Dec 7 2018, 2:09 PM
Szelethus marked an inline comment as done.Dec 7 2018, 2:21 PM
Szelethus added inline comments.
test/Analysis/Inputs/expected-plists/unix-fns.c.plist
3018 ↗(On Diff #177168)

Uhh, didnt catch this one. It does on my own pc and in the office as well, where I use a completely different directory structure.

NoQ added inline comments.Dec 7 2018, 2:22 PM
test/Analysis/Inputs/expected-plists/unix-fns.c.plist
3018 ↗(On Diff #177168)

George's diff filters probably somehow filter this out.

This revision was automatically updated to reflect the committed changes.