This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Add load/store instructions in rv64*-invalid.s
ClosedPublic

Authored by Pretty-box on Jun 13 2022, 11:56 PM.

Diff Detail

Event Timeline

Pretty-box created this revision.Jun 13 2022, 11:56 PM
Pretty-box requested review of this revision.Jun 13 2022, 11:56 PM
benshi001 added inline comments.Jun 14 2022, 5:48 AM
llvm/test/MC/RISCV/rv64zdinx-invalid.s
4

I guess you probably want fld and fsd ?

llvm/test/MC/RISCV/rv64zfh-invalid.s
12

also add invalid operand for fld/fsd along with fsw/flw ?

llvm/test/MC/RISCV/rv64zhinx-invalid.s
4

I guess you want flh/fsh ?

llvm/test/MC/RISCV/rv64zhinxmin-invalid.s
7

I guess you want flh/fsh ?

sunshaoce added inline comments.Jun 14 2022, 9:23 AM
llvm/test/MC/RISCV/rv64zdinx-invalid.s
4

In zdinx, you should use ld rather than fld or flw.

benshi001 added inline comments.Jun 14 2022, 6:23 PM
llvm/test/MC/RISCV/rv64zdinx-invalid.s
4

Sure. So we need to test neither fld/fsd nor fsw/flw is valid.

Pretty-box marked 6 inline comments as done.Jun 14 2022, 11:19 PM
Pretty-box added inline comments.
llvm/test/MC/RISCV/rv64zhinxmin-invalid.s
7

Modified RUN line -mattr

benshi001 accepted this revision.Jun 15 2022, 12:02 AM
This revision is now accepted and ready to land.Jun 15 2022, 12:02 AM
This revision was landed with ongoing or failed builds.Jun 17 2022, 12:18 AM
This revision was automatically updated to reflect the committed changes.
Pretty-box marked an inline comment as done.