This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][DWARF] Add Unit test for DW_AT_high_pc [DW_FORM_addr]
ClosedPublic

Authored by zr33 on Jun 12 2022, 11:21 PM.

Diff Detail

Event Timeline

zr33 created this revision.Jun 12 2022, 11:21 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
zr33 requested review of this revision.Jun 12 2022, 11:21 PM
Herald added a project: Restricted Project. · View Herald Transcript
ayermolo added inline comments.Jun 13 2022, 11:16 AM
bolt/test/X86/dwarf3-lowpc-highpc-convert.s
17

It's not IDX it's an offset, so maybe different name?

53

Modify path to remove your username...

399

cleanup the string

422

ditto

zr33 updated this revision to Diff 436496.Jun 13 2022, 11:41 AM

New test case to make sure DW_AT_high_pc convert to DW_AT_ranges correctly in Dwarf 3

zr33 changed the edit policy from "All Users" to "No One".Jun 13 2022, 11:48 AM
zr33 changed the visibility from "Public (No Login Required)" to "No One".
zr33 changed the edit policy from "No One" to "All Users".
zr33 updated this revision to Diff 436501.Jun 13 2022, 11:55 AM

test DW_AT_high_pc convert to DW_AT_ranges correctly in Dwarf 3

zr33 changed the visibility from "No One" to "Public (No Login Required)".Jun 13 2022, 11:56 AM

For title maybe something like
[BOLT][DWARF] Add Unit test for DW_AT_high_pc [DW_FORM_addr]

bolt/test/X86/dwarf3-lowpc-highpc-convert.s
11

Please add description of what this tests for.

zr33 retitled this revision from New test case to make sure DW_AT_high_pc convert to DW_AT_ranges correctly in Dwarf 3 to [BOLT][DWARF] Add Unit test for DW_AT_high_pc [DW_FORM_addr].Jun 13 2022, 12:38 PM
zr33 retitled this revision from [BOLT][DWARF] Add Unit test for DW_AT_high_pc [DW_FORM_addr] to [BOLT][DWARF][TEST] Add Unit test for DW_AT_high_pc [DW_FORM_addr].Jun 13 2022, 12:43 PM
zr33 retitled this revision from [BOLT][DWARF][TEST] Add Unit test for DW_AT_high_pc [DW_FORM_addr] to [BOLT][DWARF] Add Unit test for DW_AT_high_pc [DW_FORM_addr].
zr33 updated this revision to Diff 436626.Jun 13 2022, 7:43 PM
zr33 marked 4 inline comments as done.

add comment

zr33 updated this revision to Diff 436627.Jun 13 2022, 7:44 PM
zr33 marked an inline comment as done.

fix typo

ayermolo accepted this revision.Jun 14 2022, 10:02 AM
This revision is now accepted and ready to land.Jun 14 2022, 10:02 AM
ayermolo added inline comments.Jun 14 2022, 11:22 AM
bolt/test/X86/dwarf3-lowpc-highpc-convert.s
4

can you change all options to double dashes?

This revision was automatically updated to reflect the committed changes.