This is an archive of the discontinued LLVM Phabricator instance.

[mlir][NFC] Rename Bazel target aliases and consolidate targets
ClosedPublic

Authored by Mogball on Jun 9 2022, 4:54 PM.

Details

Summary

This patch completes outstanding TODOs of removing aliases bazel target names.
This patch also renames and cosolidates some bazel targets to be more in line
with their CMake counterparts, e.g. combining :LinalgOps and :LinalgInterfaces
into :LinalgDialect.

Diff Detail

Event Timeline

Mogball created this revision.Jun 9 2022, 4:54 PM
Mogball requested review of this revision.Jun 9 2022, 4:54 PM

Thank you! Can you confirm that the names we're switching to are actually the consistent pattern in CMake as well? One issue I encountered before when cleaning this up was that the CMake names weren't consistent with each other across the project, so it was a little unclear what should be changed.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 9 2022, 4:58 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

Yes, I'll be taking at look at the CMake names afterwards. This one goes after the low-hanging fruit, mostly, in the bazel targets. I'll probably do a comprehensive review to make sure everything lines up in bazel and CMake

Yes, I'll be taking at look at the CMake names afterwards. This one goes after the low-hanging fruit, mostly, in the bazel targets. I'll probably do a comprehensive review to make sure everything lines up in bazel and CMake

Sounds great, thank you. I had been thinking it would make sense to only have to change the Bazel names once, but I'm certainly not going to complain about it :-)