Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM
llvm/lib/Target/LoongArch/LoongArchISelDAGToDAG.cpp | ||
---|---|---|
35 | nit: is this variable used in any other place? could we either put it in the inner local scope or spell it out in-place? |
llvm/test/CodeGen/LoongArch/imm.ll | ||
---|---|---|
167 | Usually simple tests are placed before complex ones. |
- Address @MaskRay's comment by moving imm0 testing to the top of the test file.
- Remove the patch number in the title.
The reason why I place it after other patches is that we can obviously see the improvements from the test (introduced by early patches) updates. If this is not good, I can revert the dependency. There is no problem. Thanks.
If you think it's worthwhile, you can mention this in D127204's summary. No need to add unnecessary intermediate steps to the tests to show the effect.
Sorry. Maybe I misunderstood your last comment.
To reduce these changes to sext-zext-trunc.ll I should have to revert the dependence, right?
nit: is this variable used in any other place? could we either put it in the inner local scope or spell it out in-place?