This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][GFX9+] Support base+soffset+offset s_atc_probe's.
ClosedPublic

Authored by kosarev on Jun 1 2022, 9:50 AM.

Diff Detail

Event Timeline

kosarev created this revision.Jun 1 2022, 9:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2022, 9:50 AM
kosarev requested review of this revision.Jun 1 2022, 9:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2022, 9:50 AM
dp accepted this revision.Jun 3 2022, 9:04 AM

LGTM with a nit.

llvm/lib/Target/AMDGPU/SMInstructions.td
247

IMO these comments distract attention and make code less readable.

This revision is now accepted and ready to land.Jun 3 2022, 9:04 AM
kosarev updated this revision to Diff 434499.Jun 6 2022, 8:45 AM

Updated as suggested.

This revision was landed with ongoing or failed builds.Jun 6 2022, 8:47 AM
This revision was automatically updated to reflect the committed changes.