Resolves part of
https://github.com/llvm/llvm-project/issues/38652
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM.
llvm/lib/Target/AMDGPU/SMInstructions.td | ||
---|---|---|
215 | For my taste, these comments do not improve code readability (especially being repeated 3 times). def _SGPR_IMM : SM_Discard_Pseudo <opName, "_SGPR_IMM", (ins SReg_32:$soffset, smem_offset_mod:$offset), "$soffset$offset", 1, 1>; |
For my taste, these comments do not improve code readability (especially being repeated 3 times).
Also I think we should not dogmatically follow 80 columns rule in td files.
The following variant looks better for me despite being a bit wider than recommended: