This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][GFX9][GFX10] Support base+soffset+offset s_dcache_discard's.
ClosedPublic

Authored by kosarev on Jun 1 2022, 3:13 AM.

Diff Detail

Event Timeline

kosarev created this revision.Jun 1 2022, 3:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2022, 3:13 AM
kosarev requested review of this revision.Jun 1 2022, 3:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2022, 3:13 AM
kosarev updated this revision to Diff 433344.Jun 1 2022, 3:20 AM

Removed extra empty line.

dp accepted this revision.Jun 1 2022, 1:17 PM

LGTM.

llvm/lib/Target/AMDGPU/SMInstructions.td
215

For my taste, these comments do not improve code readability (especially being repeated 3 times).
Also I think we should not dogmatically follow 80 columns rule in td files.
The following variant looks better for me despite being a bit wider than recommended:

def _SGPR_IMM : SM_Discard_Pseudo <opName, 
  "_SGPR_IMM", (ins SReg_32:$soffset, smem_offset_mod:$offset), "$soffset$offset", 1, 1>;
This revision is now accepted and ready to land.Jun 1 2022, 1:17 PM
kosarev updated this revision to Diff 434488.Jun 6 2022, 8:31 AM

Updated as suugested.

This revision was landed with ongoing or failed builds.Jun 6 2022, 8:34 AM
This revision was automatically updated to reflect the committed changes.