[llvm-objdump][COFF] Remove duplicate data dir loading

[alvinhochun]

Summary

COFFObjectFile already initialized the pointers and checked their
ranges, so COFFDump should just reuse these pointers.

Depends on D126786

[alvinhochun]

Update commit message

[mstorsjo]

This also needs a testcase.

The description makes it sound like this is a NFC (a commit that only does pure refactoring, "No Functional Changes"), but the detail that isn't entirely obvious is that this also fixes printing (by skipping it) for the cases where there is a data directory, but the contents it points at is missing, so maybe it'd be good to spell this out a bit more clearly.

[alvinhochun]

Replacing with https://reviews.llvm.org/D126898

llvm/tools/llvm-objdump/COFFDump.cpp

 static void printTLSDirectory(const COFFObjectFile *Obj) {
   const pe32_header *PE32Header = Obj->getPE32Header();
   const pe32plus_header *PE32PlusHeader = Obj->getPE32PlusHeader();
 
   // Skip if it's not executable.
   if (!PE32Header && !PE32PlusHeader)
     return;
 
-  const data_directory *DataDir = Obj->getDataDirectory(COFF::TLS_TABLE);
-  if (!DataDir || DataDir->RelativeVirtualAddress == 0)
-    return;
-
-  uintptr_t IntPtr = 0;
-  if (Error E =
-          Obj->getRvaPtr(DataDir->RelativeVirtualAddress, IntPtr))
-    reportError(std::move(E), Obj->getFileName());
-
   if (PE32Header) {
-    auto *TLSDir = reinterpret_cast<const coff_tls_directory32 *>(IntPtr);
+    if (auto *TLSDir = Obj->getTLSDirectory32())
       printTLSDirectoryT(TLSDir);
   } else {
-    auto *TLSDir = reinterpret_cast<const coff_tls_directory64 *>(IntPtr);
+    if (auto *TLSDir = Obj->getTLSDirectory64())
       printTLSDirectoryT(TLSDir);
   }
 
   outs() << "\n";
 }
 
 static void printLoadConfiguration(const COFFObjectFile *Obj) {
   // Skip if it's not executable.
   if (!Obj->getPE32Header())
     return;
 
   // Currently only x86 is supported
   if (Obj->getMachine() != COFF::IMAGE_FILE_MACHINE_I386)
     return;
 
-  const data_directory *DataDir = Obj->getDataDirectory(COFF::LOAD_CONFIG_TABLE);
-  if (!DataDir)
-    reportError("no load config data dir", Obj->getFileName());
-
-  uintptr_t IntPtr = 0;
-  if (DataDir->RelativeVirtualAddress == 0)
+  auto *LoadConf = Obj->getLoadConfig32();
+  if (!LoadConf)
     return;
 
-  if (Error E =
-          Obj->getRvaPtr(DataDir->RelativeVirtualAddress, IntPtr))
-    reportError(std::move(E), Obj->getFileName());
-
-  auto *LoadConf = reinterpret_cast<const coff_load_configuration32 *>(IntPtr);
   outs() << "Load configuration:"
          << "\n  Timestamp: " << LoadConf->TimeDateStamp
          << "\n  Major Version: " << LoadConf->MajorVersion
          << "\n  Minor Version: " << LoadConf->MinorVersion
          << "\n  GlobalFlags Clear: " << LoadConf->GlobalFlagsClear
          << "\n  GlobalFlags Set: " << LoadConf->GlobalFlagsSet
          << "\n  Critical Section Default Timeout: " << LoadConf->CriticalSectionDefaultTimeout
          << "\n  Decommit Free Block Threshold: " << LoadConf->DeCommitFreeBlockThreshold
for (const ImportDirectoryEntryRef &DirRef : Obj->import_directories()) {
     }
     outs() << "\n";
   }
 }
 
 // Prints export tables. The export table is a table containing the list of
 // exported symbol from the DLL.
 static void printExportTable(const COFFObjectFile *Obj) {
-  outs() << "Export Table:\n";
   export_directory_iterator I = Obj->export_directory_begin();
   export_directory_iterator E = Obj->export_directory_end();
   if (I == E)
     return;
+  outs() << "Export Table:\n";
   StringRef DllName;
   uint32_t OrdinalBase;
   if (I->getDllName(DllName))
     return;
   if (I->getOrdinalBase(OrdinalBase))
     return;
   outs() << " DLL name: " << DllName << "\n";
   outs() << " Ordinal base: " << OrdinalBase << "\n";