Page MenuHomePhabricator

[llvm-objdump][COFF] Remove duplicate data dir loading
AbandonedPublic

Authored by alvinhochun on Jun 1 2022, 8:42 AM.

Details

Summary

COFFObjectFile already initialized the pointers and checked their
ranges, so COFFDump should just reuse these pointers.

Depends on D126786

Diff Detail

Event Timeline

alvinhochun created this revision.Jun 1 2022, 8:42 AM
Herald added a reviewer: MaskRay. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: rupprecht. · View Herald Transcript
alvinhochun retitled this revision from [llvm-objdump][COFF] Remove duplicate data dir loading code to [llvm-objdump][COFF] Remove duplicate data dir loading.
alvinhochun edited the summary of this revision. (Show Details)

Update commit message

alvinhochun published this revision for review.Jun 1 2022, 9:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2022, 9:33 AM
mstorsjo added a subscriber: mstorsjo.

This also needs a testcase.

The description makes it sound like this is a NFC (a commit that only does pure refactoring, "No Functional Changes"), but the detail that isn't entirely obvious is that this also fixes printing (by skipping it) for the cases where there is a data directory, but the contents it points at is missing, so maybe it'd be good to spell this out a bit more clearly.

alvinhochun planned changes to this revision.Jun 2 2022, 1:48 AM