Page MenuHomePhabricator

[pseudo] Add PSEUDO_GEN cmake cache variable to avoid nested CMake invocation
ClosedPublic

Authored by sammccall on May 31 2022, 12:10 PM.

Details

Summary

Similar to LLVM_TABLEGEN, CLANG_TABLEGEN variables

Diff Detail

Event Timeline

sammccall created this revision.May 31 2022, 12:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2022, 12:10 PM
Herald added a subscriber: mgorny. · View Herald Transcript
sammccall requested review of this revision.May 31 2022, 12:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2022, 12:10 PM
mstorsjo accepted this revision.May 31 2022, 12:57 PM

Looks reasonable to me. The variable name feels a bit un-namespaced though, but that's what the tool is called currently. Should we rename the tool and the variable to give it a bit more of a namespace prefix, like clang-pseudo-gen or so?

This revision is now accepted and ready to land.May 31 2022, 12:57 PM

Looks reasonable to me. The variable name feels a bit un-namespaced though, but that's what the tool is called currently. Should we rename the tool and the variable to give it a bit more of a namespace prefix, like clang-pseudo-gen or so?

That makes sense. I'll do that first and rename to CLANG_PSEUDO_GEN.

Renamed to CLANG_PSEUDO_GEN, landing now.