The new tests in clang/test/Driver/modules.cpp added by D120540 will fail if the
toolchain getting tested doesn't support linking. This reduces the utility of
the test since we would like a failure of this test to reflect a problem with
modules. We should already have other tests that validate linking support.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This change is fine (if I were adding the tests in the first place, I'd add -c or -S), but I'd like to understand why you have such a toolchain not supporting linking.
Such special requirements make me feel odd.
Comment Actions
Downstream we have a branch that only contains some of the required changes for z/OS support, but which we still run tests on (why this is the case is a long story, but it's something we're working on fixing, it's just going to take a very long time to do so). This test is failing on that branch. Rather than loose the test, I figured I'd improve the test and in the process get it working again on that branch.