- User Since
- Mar 2 2021, 8:38 AM (135 w, 14 h)
Jun 13 2022
Line 422 needs to be fixed before I resign or approve this change, but I have a few comments and questions as well.
May 31 2022
May 30 2022
It seems like this was the correct solution this time around, since it appears we prefer clang over clang++ if we are also specifying -std=c++XX, but for future reference instead of %clang++ the correct way of invoking clang++ from a test is %clangxx
Mar 18 2022
Mar 16 2022
Follow up on @EricWF's comments based on a video chat with him:
Since id::__get is apparently hit quite often, the extra performance we might get here because of the relaxed memory ordering instead of acquire/release ordering could potentially be significant. Not to mention that in the happy path we replace 1 atomic load (from id::__flag_.__state_) and 1 non-atomic load (from id::__id_) with a single atomic load (from id::__id_). I do have to run some benchmarks to double check, but I would be shocked if this somehow hurt performance.
Comparing the old sequence to the new sequence side by side makes this pretty obvious I think.
Mar 14 2022
Mar 11 2022
Mar 10 2022
Mar 2 2022
Mar 1 2022
Feb 28 2022
Feb 25 2022
Feb 24 2022
Feb 9 2022
Ping, since as per my previous comment, I'm pretty sure this change will have broken _LIBCPP_BUILDING_THREAD_LIBRARY_EXTERNAL.
Jan 31 2022
No change, rebase so hopefully CI passes this time
As per review comment, change heading level for Compact Unwind so it's no longer under Prolog/Epilog
Jan 28 2022
Not really sure who to add as a reviewer for this. Feel free to add/remove people.
Jan 27 2022
Jan 25 2022
Address reveiw comments
Jan 19 2022
No change. Rebase onto D117366 and re-trigger CI
@Quuxplusone I've addressed the comments you made that were easy to address. The rest will take me some time to get to as I have other items I need to work on at the moment.
Address some of @Quuxplusone's comments
Jan 14 2022
Add InternalThreadSynchronization to libcxx/docs/index.rst
Update abi lists
Fix "Duplicate explicit target name" error.
Fix copy-paste error
Remove documentation update (and move to D117372, since it's more appropriate there)
Jan 12 2022
Address review comments
Jan 10 2022
Jan 6 2022
Should this have used _LIBCPP_THREAD_ABI_VISIBILITY instead? Won't this break _LIBCPP_BUILDING_THREAD_LIBRARY_EXTERNAL? Also, why is this needed when the forward declarations already specify that the functions are inline?
Dec 14 2021
Update because of changes to dependent revisions
Rebase and address review comments