Page MenuHomePhabricator

DanielMcIntosh-IBM (Daniel McIntosh)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2021, 8:38 AM (82 w, 2 d)

Recent Activity

Jun 13 2022

DanielMcIntosh-IBM added inline comments to D127701: [docs] Minor fixes to CodeGenerator docs.
Jun 13 2022, 4:27 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM requested changes to D127701: [docs] Minor fixes to CodeGenerator docs.

Line 422 needs to be fixed before I resign or approve this change, but I have a few comments and questions as well.

Jun 13 2022, 3:48 PM · Restricted Project, Restricted Project

May 31 2022

DanielMcIntosh-IBM committed rG35b1cfc76f08: [Driver][Modules] Remove dependence on linking support from… (authored by DanielMcIntosh-IBM).
[Driver][Modules] Remove dependence on linking support from…
May 31 2022, 7:34 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM closed D126669: [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp.
May 31 2022, 7:34 AM · Restricted Project, Restricted Project

May 30 2022

DanielMcIntosh-IBM added a comment to D126669: [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp.

This change is fine (if I were adding the tests in the first place, I'd add -c or -S), but I'd like to understand why you have such a toolchain not supporting linking.
Such special requirements make me feel odd.

May 30 2022, 11:17 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM retitled D126669: [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp from Remove dependence on linking support from clang/test/Driver/modules.cpp to [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp.
May 30 2022, 10:32 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM updated subscribers of D126669: [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp.
May 30 2022, 10:29 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM added inline comments to D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules.
May 30 2022, 10:26 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM requested review of D126669: [Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp.
May 30 2022, 10:24 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM added inline comments to D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules.
May 30 2022, 9:47 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM added a comment to rG738c20e6df01: [NFC] Use %clang instead of %clang++ in tests.

It seems like this was the correct solution this time around, since it appears we prefer clang over clang++ if we are also specifying -std=c++XX, but for future reference instead of %clang++ the correct way of invoking clang++ from a test is %clangxx

May 30 2022, 9:27 AM · Restricted Project, Restricted Project

Mar 18 2022

DanielMcIntosh-IBM accepted D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Mar 18 2022, 8:30 AM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2022

DanielMcIntosh-IBM added a comment to D117372: [libcxx] switch locale from using std::call_once to __libcpp_mutex_t.

Follow up on @EricWF's comments based on a video chat with him:
Since id::__get is apparently hit quite often, the extra performance we might get here because of the relaxed memory ordering instead of acquire/release ordering could potentially be significant. Not to mention that in the happy path we replace 1 atomic load (from id::__flag_.__state_) and 1 non-atomic load (from id::__id_) with a single atomic load (from id::__id_). I do have to run some benchmarks to double check, but I would be shocked if this somehow hurt performance.
Comparing the old sequence to the new sequence side by side makes this pretty obvious I think.

Mar 16 2022, 6:45 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM added inline comments to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Mar 16 2022, 12:29 PM · Restricted Project, Restricted Project, Restricted Project

Mar 14 2022

DanielMcIntosh-IBM added inline comments to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Mar 14 2022, 3:06 PM · Restricted Project, Restricted Project, Restricted Project
DanielMcIntosh-IBM added a comment to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

The __libcpp_is_threading_api_enabled() checks if threading is enabled (POSIX ON) or not (POSIX OFF) as its name clearly indicates. It cannot be changed throughout the
live of the application but it can be set at the start of the application via env. var. _CEE_RUNOPTS=POSIX(OFF).

However, the __libcpp_might_have_multiple_threads() can be changed in the life of the application. It is needed so the single threading execution can be made optimum.

Mar 14 2022, 11:25 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

DanielMcIntosh-IBM added inline comments to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Mar 11 2022, 8:08 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2022

DanielMcIntosh-IBM added a comment to D117372: [libcxx] switch locale from using std::call_once to __libcpp_mutex_t.

Do we have tests that fire up a bunch of threads and construct various locale::ids concurrently? If not we should add some. That will allow TSAN to diagnose bugs.

Mar 10 2022, 5:20 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM added inline comments to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Mar 10 2022, 2:09 PM · Restricted Project, Restricted Project, Restricted Project
DanielMcIntosh-IBM updated the summary of D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Mar 10 2022, 11:54 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

DanielMcIntosh-IBM committed rGd636b76ecaa6: [CodeGen] Use AdjustStackOffset for Callee Saved Registers in PEI… (authored by DanielMcIntosh-IBM).
[CodeGen] Use AdjustStackOffset for Callee Saved Registers in PEI…
Mar 2 2022, 8:41 AM · Restricted Project
DanielMcIntosh-IBM closed D120668: [CodeGen] Use AdjustStackOffset for Callee Saved Registers in PEI::calculateFrameObjectOffsets.
Mar 2 2022, 8:41 AM · Restricted Project, Restricted Project

Mar 1 2022

DanielMcIntosh-IBM updated the summary of D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Mar 1 2022, 8:19 AM · Restricted Project, Restricted Project, Restricted Project

Feb 28 2022

DanielMcIntosh-IBM added a reviewer for D120668: [CodeGen] Use AdjustStackOffset for Callee Saved Registers in PEI::calculateFrameObjectOffsets: lattner.
Feb 28 2022, 11:01 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM added a comment to D120668: [CodeGen] Use AdjustStackOffset for Callee Saved Registers in PEI::calculateFrameObjectOffsets.

This does look similar at first glance. What's the point of doing this? Why were these paths split in the first place?

Feb 28 2022, 10:47 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM updated the summary of D120668: [CodeGen] Use AdjustStackOffset for Callee Saved Registers in PEI::calculateFrameObjectOffsets.
Feb 28 2022, 10:36 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM requested review of D120668: [CodeGen] Use AdjustStackOffset for Callee Saved Registers in PEI::calculateFrameObjectOffsets.
Feb 28 2022, 10:22 AM · Restricted Project, Restricted Project

Feb 25 2022

DanielMcIntosh-IBM accepted D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

LGTM

Feb 25 2022, 6:28 PM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2022

DanielMcIntosh-IBM abandoned D110351: [libcxxabi][SystemZ][z/OS] Added HybridGuard to cxa_guard.
Feb 24 2022, 1:38 PM · Restricted Project
DanielMcIntosh-IBM abandoned D112567: [libcxxabi][SystemZ][z/OS] Update libcxxabi/src/fallback_malloc.cpp to support POSIX(OFF).
Feb 24 2022, 1:38 PM · Restricted Project
DanielMcIntosh-IBM abandoned D113058: [libcxx][SystemZ][z/OS] Update libcxx/src/mutex.cpp to support POSIX(OFF).
Feb 24 2022, 1:37 PM · Restricted Project
DanielMcIntosh-IBM abandoned D113054: [libcxxabi][SystemZ][z/OS] Update libcxxabi/src/cxa_exception_storage.cpp to support POSIX(OFF).
Feb 24 2022, 1:17 PM · Restricted Project
DanielMcIntosh-IBM abandoned D113065: [libcxx][SystemZ][z/OS] Update libcxx/src/debug.cpp to accommodate POSIX(OFF).
Feb 24 2022, 1:17 PM · Restricted Project
DanielMcIntosh-IBM abandoned D113066: [libcxx][SystemZ][z/OS] Update libcxx/src/memory.cpp to accommodate POSIX(OFF).
Feb 24 2022, 1:02 PM · Restricted Project
DanielMcIntosh-IBM abandoned D113069: [libcxx][SystemZ][z/OS] Update libcxx/src/random_shuffle.cpp to accommodate POSIX(OFF).
Feb 24 2022, 1:01 PM · Restricted Project
DanielMcIntosh-IBM abandoned D110349: [libcxx][SystemZ][z/OS] Added is_threading_api_enabled and might_have_multiple_threads to __threading_support.
Feb 24 2022, 1:00 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM abandoned D117375: [libcxx][SystemZ][z/OS] added internal_threading_support.h.
Feb 24 2022, 12:59 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM added inline comments to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Feb 24 2022, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
DanielMcIntosh-IBM accepted D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Feb 24 2022, 12:50 PM · Restricted Project, Restricted Project, Restricted Project
DanielMcIntosh-IBM updated the summary of D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Feb 24 2022, 12:21 PM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2022

DanielMcIntosh-IBM added a comment to D115906: [libc++] Add a bunch of missing inline and _LIBCPP_HIDE_FROM_ABI in __threading_support.

Ping, since as per my previous comment, I'm pretty sure this change will have broken _LIBCPP_BUILDING_THREAD_LIBRARY_EXTERNAL.

Feb 9 2022, 10:40 AM · Restricted Project

Jan 31 2022

DanielMcIntosh-IBM committed rG0ee7a2c3046d: [docs] Update Prolog/Epilog Code Insertion docs to show it's still incomplete (authored by DanielMcIntosh-IBM).
[docs] Update Prolog/Epilog Code Insertion docs to show it's still incomplete
Jan 31 2022, 12:26 PM
DanielMcIntosh-IBM closed D118499: [docs] Update Prolog/Epilog Code Insertion docs to show it's still incomplete.
Jan 31 2022, 12:25 PM · Restricted Project
DanielMcIntosh-IBM updated the diff for D118499: [docs] Update Prolog/Epilog Code Insertion docs to show it's still incomplete.

No change, rebase so hopefully CI passes this time

Jan 31 2022, 8:12 AM · Restricted Project
DanielMcIntosh-IBM updated the diff for D118499: [docs] Update Prolog/Epilog Code Insertion docs to show it's still incomplete.

As per review comment, change heading level for Compact Unwind so it's no longer under Prolog/Epilog

Jan 31 2022, 8:07 AM · Restricted Project

Jan 28 2022

DanielMcIntosh-IBM added a comment to D118499: [docs] Update Prolog/Epilog Code Insertion docs to show it's still incomplete.

Not really sure who to add as a reviewer for this. Feel free to add/remove people.

Jan 28 2022, 11:47 AM · Restricted Project
DanielMcIntosh-IBM added reviewers for D118499: [docs] Update Prolog/Epilog Code Insertion docs to show it's still incomplete: arsenm, aeubanks, rogfer01.
Jan 28 2022, 11:38 AM · Restricted Project
DanielMcIntosh-IBM requested review of D118499: [docs] Update Prolog/Epilog Code Insertion docs to show it's still incomplete.
Jan 28 2022, 11:24 AM · Restricted Project

Jan 27 2022

DanielMcIntosh-IBM added a comment to D117366: [libcxx][libcxxabi][docs] Document the various places we use threading in libcxx and libcxxabi.

There's a lot of quite useful information in there. However, it's not clear to me that a "DesignDoc" is the right place to put it. I'm truly scared that this is going to get out of sync with the actual code in no time at all, especially the parts that explain the current implementation of <something>. Instead, would it make sense to improve the in-code documentation of the various parts you describe by adding those descriptions as high-level comments in the code itself, close to the implementation? Then, this design doc can stay higher level and not risk getting out of sync.

Jan 27 2022, 8:07 AM · Restricted Project

Jan 25 2022

DanielMcIntosh-IBM added inline comments to D117373: [libcxx] switch debug.cpp from using std::mutex to __libcpp_mutex_t.
Jan 25 2022, 9:06 AM · Restricted Project
DanielMcIntosh-IBM updated the diff for D117373: [libcxx] switch debug.cpp from using std::mutex to __libcpp_mutex_t.

Address reveiw comments

Jan 25 2022, 9:06 AM · Restricted Project

Jan 19 2022

DanielMcIntosh-IBM updated the diff for D117372: [libcxx] switch locale from using std::call_once to __libcpp_mutex_t.

No change. Rebase onto D117366 and re-trigger CI

Jan 19 2022, 9:18 AM · Restricted Project, Restricted Project
DanielMcIntosh-IBM added a comment to D117366: [libcxx][libcxxabi][docs] Document the various places we use threading in libcxx and libcxxabi.

@Quuxplusone I've addressed the comments you made that were easy to address. The rest will take me some time to get to as I have other items I need to work on at the moment.

Jan 19 2022, 9:03 AM · Restricted Project
DanielMcIntosh-IBM updated the diff for D117366: [libcxx][libcxxabi][docs] Document the various places we use threading in libcxx and libcxxabi.

Address some of @Quuxplusone's comments

Jan 19 2022, 9:02 AM · Restricted Project

Jan 14 2022

DanielMcIntosh-IBM updated the diff for D117366: [libcxx][libcxxabi][docs] Document the various places we use threading in libcxx and libcxxabi.

Add InternalThreadSynchronization to libcxx/docs/index.rst

Jan 14 2022, 7:09 PM · Restricted Project
DanielMcIntosh-IBM updated the diff for D117372: [libcxx] switch locale from using std::call_once to __libcpp_mutex_t.

Update abi lists

Jan 14 2022, 7:03 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM updated the diff for D117366: [libcxx][libcxxabi][docs] Document the various places we use threading in libcxx and libcxxabi.

Fix "Duplicate explicit target name" error.

Jan 14 2022, 6:43 PM · Restricted Project
DanielMcIntosh-IBM updated the summary of D117375: [libcxx][SystemZ][z/OS] added internal_threading_support.h.
Jan 14 2022, 6:30 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM added inline comments to D117375: [libcxx][SystemZ][z/OS] added internal_threading_support.h.
Jan 14 2022, 6:15 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM updated the diff for D117372: [libcxx] switch locale from using std::call_once to __libcpp_mutex_t.

Fix copy-paste error

Jan 14 2022, 6:12 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM added inline comments to D117372: [libcxx] switch locale from using std::call_once to __libcpp_mutex_t.
Jan 14 2022, 6:08 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM updated the diff for D117375: [libcxx][SystemZ][z/OS] added internal_threading_support.h.

Remove documentation update (and move to D117372, since it's more appropriate there)

Jan 14 2022, 5:25 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM updated the diff for D117372: [libcxx] switch locale from using std::call_once to __libcpp_mutex_t.

Update Documentation

Jan 14 2022, 5:22 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM updated the diff for D117375: [libcxx][SystemZ][z/OS] added internal_threading_support.h.

Update Documentation

Jan 14 2022, 5:18 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM updated the summary of D117373: [libcxx] switch debug.cpp from using std::mutex to __libcpp_mutex_t.
Jan 14 2022, 5:17 PM · Restricted Project
DanielMcIntosh-IBM updated the summary of D117372: [libcxx] switch locale from using std::call_once to __libcpp_mutex_t.
Jan 14 2022, 5:17 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM updated the summary of D117370: [libcxx][SystemZ][z/OS] Added ceeedb.h for ceeedb_multithread and ceeedb_posix.
Jan 14 2022, 5:17 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM requested review of D117375: [libcxx][SystemZ][z/OS] added internal_threading_support.h.
Jan 14 2022, 5:11 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM requested review of D117373: [libcxx] switch debug.cpp from using std::mutex to __libcpp_mutex_t.
Jan 14 2022, 5:02 PM · Restricted Project
DanielMcIntosh-IBM requested review of D117372: [libcxx] switch locale from using std::call_once to __libcpp_mutex_t.
Jan 14 2022, 5:01 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM requested review of D117370: [libcxx][SystemZ][z/OS] Added ceeedb.h for ceeedb_multithread and ceeedb_posix.
Jan 14 2022, 4:52 PM · Restricted Project, Restricted Project
DanielMcIntosh-IBM requested review of D117366: [libcxx][libcxxabi][docs] Document the various places we use threading in libcxx and libcxxabi.
Jan 14 2022, 4:10 PM · Restricted Project

Jan 12 2022

DanielMcIntosh-IBM committed rGf011a53c148a: [libcxxabi] Added convenience classes to cxa_guard (authored by DanielMcIntosh-IBM).
[libcxxabi] Added convenience classes to cxa_guard
Jan 12 2022, 2:32 PM
DanielMcIntosh-IBM closed D115369: [libcxxabi] Added convenience classes to cxa_guard.
Jan 12 2022, 2:31 PM · Restricted Project
DanielMcIntosh-IBM committed rG29be7c9c4f5d: [libcxxabi] Re-organized inheritance structure to remove CRTP in cxa_guard (authored by DanielMcIntosh-IBM).
[libcxxabi] Re-organized inheritance structure to remove CRTP in cxa_guard
Jan 12 2022, 2:31 PM
DanielMcIntosh-IBM closed D115368: [libcxxabi] Re-organized inheritance structure to remove CRTP in cxa_guard.
Jan 12 2022, 2:31 PM · Restricted Project
DanielMcIntosh-IBM committed rG847ea7621989: [libcxxabi] Pulled guard byte code out of GuardObject (authored by DanielMcIntosh-IBM).
[libcxxabi] Pulled guard byte code out of GuardObject
Jan 12 2022, 2:31 PM
DanielMcIntosh-IBM closed D115367: [libcxxabi] Pulled guard byte code out of GuardObject.
Jan 12 2022, 2:30 PM · Restricted Project
DanielMcIntosh-IBM committed rG3601ee6cfd7f: [libcxxabi] Make InitByteGlobalMutex check GetThreadID instead of… (authored by DanielMcIntosh-IBM).
[libcxxabi] Make InitByteGlobalMutex check GetThreadID instead of…
Jan 12 2022, 2:30 PM
DanielMcIntosh-IBM closed D110088: [libcxxabi] Make InitByteGlobalMutex check GetThreadID instead of PlatformThreadID.
Jan 12 2022, 2:30 PM · Restricted Project
DanielMcIntosh-IBM committed rGe42eeb88d7b2: [NFC][libcxxabi] Rename GlobalLock to GlobalMutex (authored by DanielMcIntosh-IBM).
[NFC][libcxxabi] Rename GlobalLock to GlobalMutex
Jan 12 2022, 2:29 PM
DanielMcIntosh-IBM closed D109539: [NFC][libcxxabi] Rename GlobalLock to GlobalMutex.
Jan 12 2022, 2:29 PM · Restricted Project
DanielMcIntosh-IBM updated the diff for D115368: [libcxxabi] Re-organized inheritance structure to remove CRTP in cxa_guard.

Address review comments

Jan 12 2022, 12:00 PM · Restricted Project
DanielMcIntosh-IBM retitled D115369: [libcxxabi] Added convenience classes to cxa_guard from [NFC][libcxxabi] Added convenience classes to cxa_guard to [libcxxabi] Added convenience classes to cxa_guard.
Jan 12 2022, 11:19 AM · Restricted Project
DanielMcIntosh-IBM retitled D115368: [libcxxabi] Re-organized inheritance structure to remove CRTP in cxa_guard from [NFC][libcxxabi] Re-organized inheritance structure to remove CRTP in cxa_guard to [libcxxabi] Re-organized inheritance structure to remove CRTP in cxa_guard.
Jan 12 2022, 11:18 AM · Restricted Project
DanielMcIntosh-IBM retitled D115367: [libcxxabi] Pulled guard byte code out of GuardObject from [NFC][libcxxabi] Pulled guard byte code out of GuardObject to [libcxxabi] Pulled guard byte code out of GuardObject.
Jan 12 2022, 11:18 AM · Restricted Project

Jan 10 2022

DanielMcIntosh-IBM updated the summary of D109539: [NFC][libcxxabi] Rename GlobalLock to GlobalMutex.
Jan 10 2022, 2:19 PM · Restricted Project
DanielMcIntosh-IBM updated the summary of D110088: [libcxxabi] Make InitByteGlobalMutex check GetThreadID instead of PlatformThreadID.
Jan 10 2022, 2:19 PM · Restricted Project
DanielMcIntosh-IBM updated the summary of D115367: [libcxxabi] Pulled guard byte code out of GuardObject.
Jan 10 2022, 2:18 PM · Restricted Project
DanielMcIntosh-IBM updated the summary of D115368: [libcxxabi] Re-organized inheritance structure to remove CRTP in cxa_guard.
Jan 10 2022, 2:18 PM · Restricted Project
DanielMcIntosh-IBM updated the summary of D115369: [libcxxabi] Added convenience classes to cxa_guard.
Jan 10 2022, 2:18 PM · Restricted Project
DanielMcIntosh-IBM added a comment to D115369: [libcxxabi] Added convenience classes to cxa_guard.

Ping

Jan 10 2022, 2:17 PM · Restricted Project
DanielMcIntosh-IBM added a comment to D115368: [libcxxabi] Re-organized inheritance structure to remove CRTP in cxa_guard.

Ping

Jan 10 2022, 2:16 PM · Restricted Project
DanielMcIntosh-IBM added a comment to D115906: [libc++] Add a bunch of missing inline and _LIBCPP_HIDE_FROM_ABI in __threading_support.

For the Pthread case, using _LIBCPP_THREAD_ABI_VISIBILITY and inline _LIBCPP_HIDE_FROM_ABI is equivalent.

Jan 10 2022, 10:57 AM · Restricted Project

Jan 6 2022

DanielMcIntosh-IBM added a comment to D115906: [libc++] Add a bunch of missing inline and _LIBCPP_HIDE_FROM_ABI in __threading_support.

Should this have used _LIBCPP_THREAD_ABI_VISIBILITY instead? Won't this break _LIBCPP_BUILDING_THREAD_LIBRARY_EXTERNAL? Also, why is this needed when the forward declarations already specify that the functions are inline?

Jan 6 2022, 9:43 AM · Restricted Project

Dec 14 2021

DanielMcIntosh-IBM added inline comments to D115730: [libc++] Add a helper class to write code with the strong exception guarantee.
Dec 14 2021, 4:13 PM · Restricted Project
DanielMcIntosh-IBM updated the diff for D110351: [libcxxabi][SystemZ][z/OS] Added HybridGuard to cxa_guard.

Update because of changes to dependent revisions

Dec 14 2021, 3:35 PM · Restricted Project
DanielMcIntosh-IBM retitled D115369: [libcxxabi] Added convenience classes to cxa_guard from [NFC][libcxxabi] Added convinence classes to cxa_guard to [NFC][libcxxabi] Added convenience classes to cxa_guard.
Dec 14 2021, 3:30 PM · Restricted Project
DanielMcIntosh-IBM updated the diff for D115369: [libcxxabi] Added convenience classes to cxa_guard.

Rebase and address review comments

Dec 14 2021, 2:32 PM · Restricted Project
DanielMcIntosh-IBM added inline comments to D115368: [libcxxabi] Re-organized inheritance structure to remove CRTP in cxa_guard.
Dec 14 2021, 11:16 AM · Restricted Project