This is an archive of the discontinued LLVM Phabricator instance.

[libc++] DO NOT REVIEW chrono formatting
AbandonedPublic

Authored by Mordante on May 28 2022, 3:45 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This is an incomplete not yet ready for review version of the code.

Since the output of these formatters are locale dependant it's expected
to fail on a lot of non-Linux platforms. There the list of CI's used has
been limited. There's no need to test every iteration of this patch on
all CI's.

It's intended to split this review in smaller parts for its real review.

Depends on D125606

Diff Detail

Event Timeline

Mordante created this revision.May 28 2022, 3:45 AM
Mordante requested review of this revision.May 28 2022, 3:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2022, 3:45 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante updated this revision to Diff 432714.May 28 2022, 4:32 AM

Rebased to trigger CI

Mordante updated this revision to Diff 432721.May 28 2022, 7:09 AM

Rebased to fix CI and attempts fixing several other build issues.

Mordante updated this revision to Diff 432773.May 29 2022, 2:18 AM

Rebased and applies several locale fixes.

Mordante updated this revision to Diff 432781.May 29 2022, 4:52 AM

Try to fix CI.

Mordante updated this revision to Diff 432791.May 29 2022, 9:13 AM

More CI fixes.

Mordante updated this revision to Diff 432799.May 29 2022, 10:50 AM

Another CI test, disable AIX and GCC since they have hard failures and not test failures.

Mordante updated this revision to Diff 432802.May 29 2022, 12:12 PM

More Windows fixes.

Mordante abandoned this revision.May 7 2023, 9:37 AM

The changes in this patch have landed in main via several other patches.