This is an archive of the discontinued LLVM Phabricator instance.

Differential D126516

[RISCV][NFC] Simplified code for integer promotion setcc/vp.setcc
ClosedPublic

Authored by Pretty-box on May 26 2022, 7:04 PM.

Details

Reviewers
Jimerlife
benshi001
craig.topper
Commits
rG121689a62e5b: [SelectionDAG][NFC] Simplify integer promotion in setcc/vp.setcc

Diff Detail

Unit TestsFailed

TimeTest
60,250 msx64 debian > MLIR.Examples/standalone::test.toy
60,050 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
60,060 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test

Event Timeline

Pretty-box created this revision.May 26 2022, 7:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2022, 7:04 PM
Herald added subscribers: sunshaoce, VincentWu, luke957 and 15 others. · View Herald Transcript
Pretty-box requested review of this revision.May 26 2022, 7:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2022, 7:04 PM
Herald added subscribers: llvm-commits, • pcwang-thead, eopXD. · View Herald Transcript
craig.topper added inline comments.May 26 2022, 7:15 PM
llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
1956

The opcode checking assert was useful. Don't delete it.

Pretty-box updated this revision to Diff 432448.May 26 2022, 7:29 PM
Pretty-box marked an inline comment as done.
craig.topper accepted this revision.May 26 2022, 8:06 PM

LGTM

This revision is now accepted and ready to land.May 26 2022, 8:06 PM
Harbormaster completed remote builds in B166581: Diff 432448.May 26 2022, 8:10 PM
This revision was landed with ongoing or failed builds.May 26 2022, 10:50 PM
Closed by commit rG121689a62e5b: [SelectionDAG][NFC] Simplify integer promotion in setcc/vp.setcc (authored by Pretty-box, committed by benshi001). · Explain Why
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rG121689a62e5b: [SelectionDAG][NFC] Simplify integer promotion in setcc/vp.setcc.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
3 lines

Diff 432448

llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp

Show First 20 Lines • Show All 1,943 Lines • ▼ Show 20 Lines
SDValue DAGTypeLegalizer::PromoteIntOp_SETCC(SDNode *N, unsigned OpNo) { SDValue DAGTypeLegalizer::PromoteIntOp_SETCC(SDNode *N, unsigned OpNo) {
assert(OpNo == 0 && "Don't know how to promote this operand!"); assert(OpNo == 0 && "Don't know how to promote this operand!");
SDValue LHS = N->getOperand(0); SDValue LHS = N->getOperand(0);
SDValue RHS = N->getOperand(1); SDValue RHS = N->getOperand(1);
PromoteSetCCOperands(LHS, RHS, cast<CondCodeSDNode>(N->getOperand(2))->get()); PromoteSetCCOperands(LHS, RHS, cast<CondCodeSDNode>(N->getOperand(2))->get());
// The CC (#2) is always legal. // The CC (#2) is always legal.
if (N->getNumOperands() == 3) if (N->getOpcode() == ISD::SETCC)
return SDValue(DAG.UpdateNodeOperands(N, LHS, RHS, N->getOperand(2)), 0); return SDValue(DAG.UpdateNodeOperands(N, LHS, RHS, N->getOperand(2)), 0);
assert(N->getNumOperands() == 5 && "Unexpected number of operands!");
assert(N->getOpcode() == ISD::VP_SETCC && "Expected VP_SETCC opcode"); assert(N->getOpcode() == ISD::VP_SETCC && "Expected VP_SETCC opcode");
craig.topperUnsubmitted
Done
ReplyInline Actions

The opcode checking assert was useful. Don't delete it.

craig.topper: The opcode checking assert was useful. Don't delete it.
return SDValue(DAG.UpdateNodeOperands(N, LHS, RHS, N->getOperand(2), return SDValue(DAG.UpdateNodeOperands(N, LHS, RHS, N->getOperand(2),
N->getOperand(3), N->getOperand(4)), N->getOperand(3), N->getOperand(4)),
0); 0);
} }
SDValue DAGTypeLegalizer::PromoteIntOp_Shift(SDNode *N) { SDValue DAGTypeLegalizer::PromoteIntOp_Shift(SDNode *N) {
return SDValue(DAG.UpdateNodeOperands(N, N->getOperand(0), return SDValue(DAG.UpdateNodeOperands(N, N->getOperand(0),
▲ Show 20 Lines • Show All 3,527 Lines • Show Last 20 Lines