Add integer promote support for vp.gather and vp.scatter
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vpgather.ll | ||
---|---|---|
13 | This isn't correct code for the IR. This is loading 32 bit elements from memory, but the memory value is only 7 bits. |
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vpgather.ll | ||
---|---|---|
13 | Oops. I guess it's reading 8 bit elements. So maybe it's ok. |
llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp | ||
---|---|---|
2128 | Do we need to promote index and mask for gather? We don't seem to be testing index and mask promotion for scatter. |
llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp | ||
---|---|---|
2128 | Now I couldn't write index and mask promotion test in RISCV. I think index and mask promotion are unnecessary to RISCV. I add PromoteIntOp_VP_SCATTER with reference to PromoteIntOp_MSCATTER. |
llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp | ||
---|---|---|
2128 | Thinking about it. Does RISC-V even need the promote support for data? Shouldn’t the vectorizer be using isLegalMaskedGather from TTI? |
Do we need to promote index and mask for gather?
We don't seem to be testing index and mask promotion for scatter.