Paths

Table of Contentst

[libc++] Remove unused __functional includes
ClosedPublic
Actions

Authored by philnik on May 20 2022, 3:46 PM.

Details

Reviewers

ldionne
Mordante
var-const

Group Reviewers

Restricted Project

Commits

rG34f73804ed60: [libc++] Remove unused __functional includes

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

philnik created this revision.May 20 2022, 3:46 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 3:46 PM

Herald added a subscriber: arphaman. · View Herald Transcript

philnik requested review of this revision.May 20 2022, 3:46 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 3:46 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Harbormaster completed remote builds in B165604: Diff 431081.May 20 2022, 5:07 PM

Fix CI

Herald added subscribers: smeenai, arichardson. · View Herald TranscriptMay 21 2022, 9:18 AM

Harbormaster completed remote builds in B165653: Diff 431142.May 21 2022, 9:34 AM

I don't understand this review's title in relationship with the diff. Is it an error?

@ldionne Oops, looks like I uploaded the wrong diff once.

Harbormaster completed remote builds in B165875: Diff 431422.May 23 2022, 12:10 PM

This needs a release note to mention that we removed some includes of <functional>, since this may break users. Other than that, LGTM.

This revision is now accepted and ready to land.May 27 2022, 1:51 PM

In D126098#3543159, @ldionne wrote:

This needs a release note to mention that we removed some includes of <functional>, since this may break users. Other than that, LGTM.

We've already added a release note in D124123.

Closed by commit rG34f73804ed60: [libc++] Remove unused __functional includes (authored by philnik). · Explain WhyMay 28 2022, 1:12 AM

This revision was automatically updated to reflect the committed changes.

philnik added a commit: rG34f73804ed60: [libc++] Remove unused __functional includes.

Revision Contents
Changeset List

Path

Size

libcxx/

include/

__algorithm/

sort.h

1 line

__format/

format_arg.h

2 lines

experimental/

coroutine

1 line

ext/

1 line

1 line

6 lines

2 lines

8 lines

1 line

1 line

7 lines

1 line

6 lines

5 lines

1 line

1 line

4 lines

7 lines

test/

libcxx/

algorithms/

debug_less.pass.cpp

3 lines

sort_stability.pass.cpp

1 line

std/

algorithms/

alg.nonmodifying/

alg.foreach/

for_each_n.pass.cpp

1 line

concepts/

concepts.callable/

concept.invocable/

invocable.compile.pass.cpp

1 line

concept.regularinvocable/

regular_invocable.compile.pass.cpp

1 line

containers/

sequences/

forwardlist/

forwardlist.ops/

remove_if.pass.cpp

1 line

unique_pred.pass.cpp

3 lines

list/

list.ops/

unique_pred.pass.cpp

1 line

experimental/

language.support/

support.coroutines/

coroutine.handle/

coroutine.handle.hash/

hash.pass.cpp

1 line

iterators/

predef.iterators/

move.iterators/

move.iterator/

types.pass.cpp

1 line

numerics/

numeric.ops/

reduce/

reduce_init_op.pass.cpp

1 line

ranges/

range.adaptors/

range.join.view/

sentinel/

eq.pass.cpp

1 line

range.zip/

types.h

1 line

support/

deduction_guides_sfinae_checks.h

1 line

Diff 431422

View Options

libcxx/include/__algorithm/sort.h

View Options

libcxx/include/__format/format_arg.h

View Options

libcxx/include/experimental/coroutine

View Options

libcxx/include/ext/hash_map

View Options

libcxx/include/ext/hash_set

View Options

libcxx/include/iterator

View Options

libcxx/include/map

View Options

libcxx/include/memory

View Options

libcxx/include/queue

View Options

libcxx/include/set

View Options

libcxx/include/string

View Options

libcxx/include/string_view

View Options

libcxx/include/tuple

View Options

libcxx/include/typeindex

View Options

libcxx/include/unordered_map

View Options

libcxx/include/unordered_set

View Options

libcxx/include/variant

View Options

libcxx/include/vector

View Options

libcxx/test/libcxx/algorithms/debug_less.pass.cpp

View Options

libcxx/test/libcxx/algorithms/sort_stability.pass.cpp

View Options

libcxx/test/std/algorithms/alg.nonmodifying/alg.foreach/for_each_n.pass.cpp

View Options

libcxx/test/std/concepts/concepts.callable/concept.invocable/invocable.compile.pass.cpp

View Options

libcxx/test/std/concepts/concepts.callable/concept.regularinvocable/regular_invocable.compile.pass.cpp

View Options

libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/remove_if.pass.cpp

View Options

libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/unique_pred.pass.cpp

View Options

libcxx/test/std/containers/sequences/list/list.ops/unique_pred.pass.cpp

View Options

libcxx/test/std/experimental/language.support/support.coroutines/coroutine.handle/coroutine.handle.hash/hash.pass.cpp

View Options

libcxx/test/std/iterators/predef.iterators/move.iterators/move.iterator/types.pass.cpp

View Options

libcxx/test/std/numerics/numeric.ops/reduce/reduce_init_op.pass.cpp

View Options

libcxx/test/std/ranges/range.adaptors/range.join.view/sentinel/eq.pass.cpp

View Options

libcxx/test/std/ranges/range.adaptors/range.zip/types.h

View Options

libcxx/test/support/deduction_guides_sfinae_checks.h

[libc++] Remove unused __functional includesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 431422

libcxx/include/__algorithm/sort.h

libcxx/include/__format/format_arg.h

libcxx/include/experimental/coroutine

libcxx/include/ext/hash_map

libcxx/include/ext/hash_set

libcxx/include/iterator

libcxx/include/map

libcxx/include/memory

libcxx/include/queue

libcxx/include/set

libcxx/include/string

libcxx/include/string_view

libcxx/include/tuple

libcxx/include/typeindex

libcxx/include/unordered_map

libcxx/include/unordered_set

libcxx/include/variant

libcxx/include/vector

libcxx/test/libcxx/algorithms/debug_less.pass.cpp

libcxx/test/libcxx/algorithms/sort_stability.pass.cpp

libcxx/test/std/algorithms/alg.nonmodifying/alg.foreach/for_each_n.pass.cpp

libcxx/test/std/concepts/concepts.callable/concept.invocable/invocable.compile.pass.cpp

libcxx/test/std/concepts/concepts.callable/concept.regularinvocable/regular_invocable.compile.pass.cpp

libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/remove_if.pass.cpp

libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/unique_pred.pass.cpp

libcxx/test/std/containers/sequences/list/list.ops/unique_pred.pass.cpp

libcxx/test/std/experimental/language.support/support.coroutines/coroutine.handle/coroutine.handle.hash/hash.pass.cpp

libcxx/test/std/iterators/predef.iterators/move.iterators/move.iterator/types.pass.cpp

libcxx/test/std/numerics/numeric.ops/reduce/reduce_init_op.pass.cpp

libcxx/test/std/ranges/range.adaptors/range.join.view/sentinel/eq.pass.cpp

libcxx/test/std/ranges/range.adaptors/range.zip/types.h

libcxx/test/support/deduction_guides_sfinae_checks.h

[libc++] Remove unused __functional includes
ClosedPublic
Actions

Revision Contents
Changeset List