Thanks for the cleanup.
I feel this list is getting at the point were it becomes hard to read, and I expect the list to keep growing. I would suggest to change this entry to
- Some libc++ headers no longer transitively include all of - ``<algorithm>``, - ``<chrono>``, - ``<functional>``, and - ``<utility>``. If, after updating libc++, you see compiler errors related to missing declarations in namespace ``std``, it might be because one of your source files now needs to include one or more of the above headers.
(The formatting is untested.)
If you want to keep it as is, then please add Oxford comma's in both listings. (The first also misses a space.)
``<functional>``, and ``<utility>``. If, after updating libc++, you see compiler errors
Nit: I think it would make sense to add a colon after of to precede the list.
Optional: I think it's more common for list elements to end in ; semicolons.
I'd remove this and -- it seems largely like a leftover from the previous state when this was a sentence and not a list.
@var-const What would you like to see in the description? The consensus was that we remove a few of the transitive includes in the libc++15 release cycle.
I don't think that Louis has to take a look here, since he approved of the direction. The entire reason this is in it's own patch is to be able to easily revert it just in case we break something in a really bad way.
I think it makes more sense to remove them entirely.
LGTM. I understand that this will probably cause a bit of breakage, but it's trivial to fix and we have to get going if we ever want to clean up our transitive includes.
Pinging libc++ vendors for awareness.