Page MenuHomePhabricator

[mlir][NFC] Add isBool to replace isInteger(1).
AbandonedPublic

Authored by jacquesguan on May 20 2022, 2:08 AM.

Details

Summary

There are many situations that we want to determine that if the type is a bool type in mlir. Using isBool instead of isInteger should make the code more clear.

Diff Detail

Event Timeline

jacquesguan created this revision.May 20 2022, 2:08 AM
Herald added a reviewer: sjarus. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
jacquesguan requested review of this revision.May 20 2022, 2:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 2:08 AM
rriddle requested changes to this revision.May 20 2022, 2:12 AM

I'd prefer to keep this as-is, we don't use bool to refer to i1 types anywhere in the source.

This revision now requires changes to proceed.May 20 2022, 2:12 AM
jacquesguan abandoned this revision.May 23 2022, 7:14 PM