This patch changes scripts to add libunwind CI on AIX. Test config file ibm-libunwind-shared.cfg.in is introduced for testing on AIX.
Details
- Reviewers
ldionne MaskRay compnerd daltenty - Group Reviewers
Restricted Project Restricted Project - Commits
- rGdfaee3c9cfa1: [libunwind][ci][AIX] Add libunwind to buildbot CI
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Seems fine to me for libunwind, but I don't know the build bot setup enough. I will give a LGTM if you still lack an approval to make #libunwind green :)
libunwind/test/configs/ibm-libunwind-shared.cfg.in | ||
---|---|---|
2 | Delete # with no text. I know that you copy the style from another file in the directory, but it seems that libcxx/test/configs/*.cfg.in files don't have the redundant #. |
libunwind/test/configs/ibm-libunwind-shared.cfg.in | ||
---|---|---|
2 | Deleted the empty line with a leading # sign at the top of the file. The current line 2 is kept which is consistent with libcxx/test/configs/ibm-libc++-shared.cfg.in. |
LGTM after my suggestion in run-buildbot.
libcxx/utils/ci/run-buildbot | ||
---|---|---|
603–610 | This can now become simply: generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AIX.cmake" \ -DLIBCXX_TEST_CONFIG="ibm-libc++-shared.cfg.in" \ -DLIBCXXABI_TEST_CONFIG="ibm-libc++abi-shared.cfg.in" \ -DLIBUNWIND_TEST_CONFIG="ibm-libunwind-shared.cfg.in" check-runtimes |
libcxx/utils/ci/run-buildbot | ||
---|---|---|
603–610 | Changed as suggested, thanks! |
This can now become simply: