This is an archive of the discontinued LLVM Phabricator instance.

[libunwind][ci][AIX] Add libunwind to buildbot CI
ClosedPublic

Authored by xingxue on May 19 2022, 1:49 PM.

Details

Reviewers
ldionne
MaskRay
compnerd
daltenty
Group Reviewers
Restricted Project
Restricted Project
Commits
rGdfaee3c9cfa1: [libunwind][ci][AIX] Add libunwind to buildbot CI
Summary

This patch changes scripts to add libunwind CI on AIX. Test config file ibm-libunwind-shared.cfg.in is introduced for testing on AIX.

Diff Detail

Event Timeline

xingxue created this revision.May 19 2022, 1:49 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 19 2022, 1:49 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
xingxue requested review of this revision.May 19 2022, 1:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 1:49 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Seems fine to me for libunwind, but I don't know the build bot setup enough. I will give a LGTM if you still lack an approval to make #libunwind green :)

MaskRay added inline comments.May 19 2022, 1:59 PM
libunwind/test/configs/ibm-libunwind-shared.cfg.in
23

Why is LIBPATH needed?

35

delete the trailing blank line

xingxue updated this revision to Diff 430805.May 19 2022, 2:24 PM
xingxue marked 2 inline comments as done.

Deleted a trailing empty line in file ibm-libunwind-shared.cfg.in.

libunwind/test/configs/ibm-libunwind-shared.cfg.in
23

The AIX linker/loader does not support $ORIGIN so setting env var LIBPATH makes sure the loader loads libraries from the directories it specifies.

35

Done.

xingxue updated this revision to Diff 430993.May 20 2022, 9:16 AM
xingxue edited the summary of this revision. (Show Details)

Rebased and picked up the change in D125981 which introduces the cmake-bridge.cfg.in file to reduce the libunwind test config duplication. Thanks, @ldionne!

MaskRay accepted this revision.May 20 2022, 10:32 AM
MaskRay added inline comments.
libunwind/test/configs/ibm-libunwind-shared.cfg.in
2

Delete # with no text. I know that you copy the style from another file in the directory, but it seems that libcxx/test/configs/*.cfg.in files don't have the redundant #.

xingxue updated this revision to Diff 431009.May 20 2022, 10:58 AM

Deleted an empty line with a leading # sign as suggested.

xingxue marked an inline comment as done.May 20 2022, 11:04 AM
xingxue added inline comments.
libunwind/test/configs/ibm-libunwind-shared.cfg.in
2

Deleted the empty line with a leading # sign at the top of the file. The current line 2 is kept which is consistent with libcxx/test/configs/ibm-libc++-shared.cfg.in.

ldionne accepted this revision.Jun 1 2022, 10:43 AM

LGTM after my suggestion in run-buildbot.

libcxx/utils/ci/run-buildbot
603–610

This can now become simply:

generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AIX.cmake" \
                   -DLIBCXX_TEST_CONFIG="ibm-libc++-shared.cfg.in" \
                   -DLIBCXXABI_TEST_CONFIG="ibm-libc++abi-shared.cfg.in" \
                   -DLIBUNWIND_TEST_CONFIG="ibm-libunwind-shared.cfg.in"
check-runtimes
This revision is now accepted and ready to land.Jun 1 2022, 10:43 AM
xingxue updated this revision to Diff 433476.Jun 1 2022, 11:55 AM
xingxue marked an inline comment as done.

Addressed comment - changed as per suggestion.

xingxue marked an inline comment as done.Jun 1 2022, 11:56 AM
xingxue added inline comments.
libcxx/utils/ci/run-buildbot
603–610

Changed as suggested, thanks!

This revision was automatically updated to reflect the committed changes.
xingxue marked an inline comment as done.