Page MenuHomePhabricator

[mlir] do not elide dialect prefix for ops with dots in the name
ClosedPublic

Authored by ftynse on May 19 2022, 7:23 AM.

Details

Summary

For the hypothetical "a.b.c" op printed within a region that declares "a" as
the default dialect, MLIR would currently elide the "a." prefix and only print
"b.c". However, this becomes ambiguous while parsing as "b.c" may be exist as
the "c" op in the "b" dialect. If it does not, the parsing currently fails. Do
not elide the default dialect if the op name contains further dots to avoid the
ambiguity.

See https://discourse.llvm.org/t/dropping-dialect-prefix-for-ops-with-multiple-dots-in-the-name/62562

Diff Detail

Event Timeline

ftynse created this revision.May 19 2022, 7:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 7:23 AM
ftynse requested review of this revision.May 19 2022, 7:23 AM
rriddle accepted this revision.May 19 2022, 2:27 PM

LG, thanks!

This revision is now accepted and ready to land.May 19 2022, 2:27 PM