Page MenuHomePhabricator

[mlir] Remove the `type` keyword from type alias definitions
ClosedPublic

Authored by rriddle on May 12 2022, 1:33 PM.

Details

Summary

This was carry over from LLVM IR where the alias definition can
be ambiguous, but MLIR type aliases have no such problems.
Having the type keyword is superfluous and doesn't add anything.
This commit drops it, which also nicely aligns with the syntax for
attribute aliases (which doesn't have a keyword).

Diff Detail

Event Timeline

rriddle created this revision.May 12 2022, 1:33 PM
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
rriddle requested review of this revision.May 12 2022, 1:33 PM
rriddle added inline comments.May 12 2022, 1:34 PM
mlir/utils/tree-sitter-mlir/grammar.js
10–13

Looks like clang-format got a little trigger happy here, will revert the unrelated changes.

rriddle updated this revision to Diff 429063.May 12 2022, 1:36 PM

LGTM for sparse

mehdi_amini accepted this revision.May 16 2022, 2:52 AM
This revision is now accepted and ready to land.May 16 2022, 2:52 AM
This revision was landed with ongoing or failed builds.May 16 2022, 1:57 PM
This revision was automatically updated to reflect the committed changes.