This is an archive of the discontinued LLVM Phabricator instance.

Rename `MCFixedLenDisassembler.h` as `MCDecoderOps.h`
ClosedPublic

Authored by 0x59616e on May 4 2022, 11:58 PM.

Details

Summary

The name MCFixedLenDisassembler.h is out of date after D120958.

Rename it as MCDecoderOps.h to reflect the change.

Diff Detail

Event Timeline

0x59616e created this revision.May 4 2022, 11:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2022, 11:58 PM
0x59616e requested review of this revision.May 4 2022, 11:58 PM
0x59616e retitled this revision from Rename `MCFixedLenDisassembler.h` as `MCDecoderOps.h` The name `MCFixedLenDisassembler.h` is out of date after D120958. Rename it as `MCDecoderOps.h` to reflect the change. to Rename `MCFixedLenDisassembler.h` as `MCDecoderOps.h`.May 4 2022, 11:58 PM
0x59616e edited the summary of this revision. (Show Details)
0x59616e edited the summary of this revision. (Show Details)
0x59616e updated this revision to Diff 427218.May 5 2022, 12:13 AM

change the header guard

myhsu accepted this revision.May 5 2022, 11:20 AM

LGTM. Please fix the include guard though

llvm/include/llvm/MC/MCDecoderOps.h
11

ditto the next line

This revision is now accepted and ready to land.May 5 2022, 11:20 AM
0x59616e updated this revision to Diff 427498.May 5 2022, 5:17 PM

fix the include guard

This revision was landed with ongoing or failed builds.May 14 2022, 5:45 PM
This revision was automatically updated to reflect the committed changes.
This comment was removed by 0x59616e.

@myhsu this file has dependency on MCFixedLenDisassembler.h, but I'm not quite sure whether we should take care of it, given that I did not encounter any failure during building and testing. What's your opinion ?