Page MenuHomePhabricator

[test-suite][cmake] sort unit test targets
ClosedPublic

Authored by gracejennings on May 2 2022, 3:58 PM.

Details

Summary

This patch sorts unit test targets into directories corresponding to the test source file directories to improve target navigation.

Diff Detail

Event Timeline

gracejennings created this revision.May 2 2022, 3:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2022, 3:58 PM
Herald added subscribers: pmatos, asb, ormris and 8 others. · View Herald Transcript
gracejennings requested review of this revision.May 2 2022, 3:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2022, 3:58 PM

IIUC this only affects IDE project generation. This makes sense to me, though I'll give others a few days to take a look as well in case they have any thoughts on the organization.

smeenai accepted this revision.May 6 2022, 3:42 PM

LGTM

This revision is now accepted and ready to land.May 6 2022, 3:42 PM

LGTM

Thank you for the review! I don't yet have commit access. Would you commit the change on my behalf?

LGTM

Thank you for the review! I don't yet have commit access. Would you commit the change on my behalf?

Sorry, I was out last week; I'll do so now. What name and email address would you like the commit to use?

LGTM

Thank you for the review! I don't yet have commit access. Would you commit the change on my behalf?

Sorry, I was out last week; I'll do so now. What name and email address would you like the commit to use?

No worries, thanks! Grace Jennings gjennings@microsoft.com

This revision was automatically updated to reflect the committed changes.