This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][profile][RISCV] Enable profile for RISC-V
ClosedPublic

Authored by kito-cheng on Apr 28 2022, 2:01 AM.

Details

Summary

Profile library are written by standard libraries or POSIX calls depend on target support, so there is no porting effort for the target, we could enable that for both RV32 and RV64, verified on the RV64 platform.

Diff Detail

Event Timeline

kito-cheng created this revision.Apr 28 2022, 2:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 2:01 AM
kito-cheng requested review of this revision.Apr 28 2022, 2:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 2:01 AM
Herald added subscribers: Restricted Project, pcwang-thead, eopXD. · View Herald Transcript

Profile library are written by standard libraries, so there is no porting effort for the target,

in standard libraries?

I think this is inappropriate. profile has some #ifdef and uses some POSIX stuff, there is still porting risk, just doesn't affect portability on many architectures including RISC-V.
You may add RISCV32 now. The test can be disabled on RISCV32 if fails.

Changes:

  • Also enable for RV32
kito-cheng retitled this revision from [compiler-rt][profile][RISCV] Enable profile for RISCV64 to [compiler-rt][profile][RISCV] Enable profile for RISC-V.Apr 29 2022, 3:45 AM
kito-cheng edited the summary of this revision. (Show Details)
kito-cheng added a reviewer: MaskRay.

@MaskRay summary and title update, thanks :)

MaskRay accepted this revision.Apr 29 2022, 9:08 AM
This revision is now accepted and ready to land.Apr 29 2022, 9:08 AM