Page MenuHomePhabricator

[LegacyPM] Remove DataFlowSanitizerLegacyPass
Needs ReviewPublic

Authored by MaskRay on Apr 27 2022, 10:16 PM.

Details

Reviewers
browneee
vitalybuka
ctetreau
Group Reviewers
Restricted Project
Summary

Using the legacy PM for the optimization pipeline was deprecated in 13.0.0.
Following recent changes to remove non-core features of the legacy
PM/optimization pipeline, remove DataFlowSanitizerLegacyPass.

Diff Detail

Unit TestsFailed

TimeTest
70 msx64 debian > LLVM.Instrumentation/DataFlowSanitizer::abilist.ll
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/abilist.ll -dfsan -dfsan-abilist=/var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/Inputs/abilist.txt -S | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/abilist.ll
70 msx64 debian > LLVM.Instrumentation/DataFlowSanitizer::abilist_aggregate.ll
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/abilist_aggregate.ll -dfsan -dfsan-abilist=/var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/Inputs/abilist.txt -S | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/abilist_aggregate.ll
60 msx64 debian > LLVM.Instrumentation/DataFlowSanitizer::args-unreachable-bb.ll
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/args-unreachable-bb.ll -dfsan -verify -S | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/args-unreachable-bb.ll
50 msx64 debian > LLVM.Instrumentation/DataFlowSanitizer::arith.ll
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/arith.ll -dfsan -S | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/arith.ll
60 msx64 debian > LLVM.Instrumentation/DataFlowSanitizer::array.ll
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/array.ll -dfsan -dfsan-event-callbacks=true -S | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Instrumentation/DataFlowSanitizer/array.ll --check-prefixes=CHECK,EVENT_CALLBACKS
View Full Test Results (42 Failed)

Event Timeline

MaskRay created this revision.Apr 27 2022, 10:16 PM
Herald added a reviewer: ctetreau. · View Herald Transcript
Herald added a reviewer: ctetreau. · View Herald Transcript
Herald added a reviewer: ctetreau. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
MaskRay requested review of this revision.Apr 27 2022, 10:16 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 27 2022, 10:16 PM
MaskRay edited the summary of this revision. (Show Details)Apr 27 2022, 10:16 PM

Ah, I see. Seems that they need to migrate away.
The legacy passes for asan/msan/tsan have all been removed now...