This is an archive of the discontinued LLVM Phabricator instance.

[NFC][AMDGPU][CodeGen] Use ArrayRef in TargetLowering functions
ClosedPublic

Authored by sunshaoce on Apr 27 2022, 1:53 AM.

Diff Detail

Event Timeline

sunshaoce created this revision.Apr 27 2022, 1:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 1:53 AM
sunshaoce requested review of this revision.Apr 27 2022, 1:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 1:53 AM

Sorry for delay, thanks for doing this!
This is LGTM, except it needs a rebase: ISD::SCALAR_TO_VECTOR for Vec16 has changed since this was created.

llvm/lib/Target/AMDGPU/SIISelLowering.cpp
617

ISD::SCALAR_TO_VECTOR was changed to Custom in the D124734.

arsenm added inline comments.May 17 2022, 2:53 PM
llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
147–151

Braces

148

Braces

sunshaoce updated this revision to Diff 430213.May 17 2022, 5:59 PM
sunshaoce marked 3 inline comments as done.

Address comments.

This revision is now accepted and ready to land.May 17 2022, 7:25 PM
This revision was landed with ongoing or failed builds.May 17 2022, 7:50 PM
This revision was automatically updated to reflect the committed changes.