This is an archive of the discontinued LLVM Phabricator instance.

[NVPTX][tests] add "XFAIL: nvptx" for some tests
ClosedPublic

Authored by i-chebykin on Apr 20 2022, 2:12 PM.

Details

Summary

Some tests failed for NVPTX target, but it seems that NVPTX will be fixed and the tests will pass.
So, just mark the tests as XFAIL

Diff Detail

Event Timeline

i-chebykin created this revision.Apr 20 2022, 2:12 PM
i-chebykin requested review of this revision.Apr 20 2022, 2:12 PM
tra accepted this revision.Apr 20 2022, 3:11 PM

Looks OK, though on a closer look not all the disabled tests are the fault of NVPTX. If those tests are easy to fix, I'd prefer that.
If not, I'm fine with disabling them for NVPTX, they don't seem to be particularly interesting.

llvm/test/CodeGen/Generic/addr-label.ll
6

Wrong description?
AFAICT it fails with a crash on failure to select https://godbolt.org/z/cdfE3bo4W:
Cannot select: 0x5608e9078c70: i64 = BlockAddress<@test1b, %test_label> 0

llvm/test/CodeGen/Generic/inline-asm-mem-clobber.ll
6

This test should've used CHECK-DAG as the order in which code/data is emitted is not guaranteed.
It should also have used G when it was checking for the variable name. @G is only used in a comment in the x86 assembly.

llvm/test/CodeGen/Generic/live-debug-label.ll
3

It's the test problem -- it should not have assumed basic block order.

41–44

Something like this would probably work better:

; CHECK: {{bye\.thread21|if\.then5}}:
; CHECK: DBG_LABEL !14
; Skip to the next label.
; CHECK: {{^\s+bb\.}}
; CHECK: {{bye\.thread21|if\.then5}}:
; CHECK: DBG_LABEL !14
; Skip to the next label.
; CHECK: {{^\s+bb\.}}
; CHECK-NOT: DBG_LABEL !14
This revision is now accepted and ready to land.Apr 20 2022, 3:11 PM
i-chebykin added inline comments.Apr 22 2022, 12:49 PM
llvm/test/CodeGen/Generic/addr-label.ll
6

Right, this is a typo

llvm/test/CodeGen/Generic/live-debug-label.ll
41–44

Not sure that we can have simple test for both x86 and nvptx here
I suggest either XFAIL: nvptx or do not touch the test in this commit

tra added inline comments.Apr 22 2022, 12:53 PM
llvm/test/CodeGen/Generic/inline-asm-mem-clobber.ll
6

I think this test should be fixed instead of disabling it.

llvm/test/CodeGen/Generic/live-debug-label.ll
41–44

OK.

I do not have commit access yet. Could someone help me to land the patch?

This revision was automatically updated to reflect the committed changes.