I found there are some patches which removed legacy passes. So I am wondering if we could remove the legacy passes in coroutines now. So that we could simplify the codes further.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/tools/opt/opt.cpp | ||
---|---|---|
374 | You can also drop the option now. It is only meaningful with legacy PM, as coroutines are always enabled with new PM. |
llvm/test/Transforms/Coroutines/coro-async-addr-lifetime-start-bug.ll | ||
---|---|---|
1–2 | I am wondering if the 2 tests are redundant? |
llvm/test/Transforms/Coroutines/coro-async-addr-lifetime-start-bug.ll | ||
---|---|---|
1–2 | Yes, these are redundant, you can drop one of them. |
Comment Actions
I found there are some patches which removed legacy passes.
Yes. I have sent some after I saw nikic did for some.
An important user of us swiftshader uses createCoroCleanupLegacyPass. Would you mind giving us few days so that they can migrate away?
I am wondering if the 2 tests are redundant?