This is an archive of the discontinued LLVM Phabricator instance.

Differential D123097

[RISCV] Remove redundant enabling of IAS for Clang, NFC
ClosedPublic

Authored by brad on Apr 4 2022, 4:15 PM.

Details

Reviewers
kito-cheng
MaskRay
Commits
rG4875ff1dc90b: [RISCV] Remove redundant enabling of IAS for Clang, NFC
Summary

Generic_GCC::IsIntegratedAssemblerDefault() already takes care of RISCV. Remove the redundant enabling of IAS with Clang.

Diff Detail

Event Timeline

brad created this revision.Apr 4 2022, 4:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 4:15 PM
Herald added subscribers: sunshaoce, VincentWu, luke957 and 26 others. · View Herald Transcript
brad requested review of this revision.Apr 4 2022, 4:15 PM
Herald added subscribers: cfe-commits, • pcwang-thead, eopXD, MaskRay. · View Herald TranscriptApr 4 2022, 4:15 PM
MaskRay accepted this revision.Apr 4 2022, 4:28 PM

It's conventional to add NFC to the subject line to indicate "no functional change".

This revision is now accepted and ready to land.Apr 4 2022, 4:28 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptApr 4 2022, 4:28 PM
brad retitled this revision from [RISCV] Remove redundant enabling of IAS for Clang to [RISCV] Remove redundant enabling of IAS for Clang, NFC.Apr 4 2022, 4:36 PM
Harbormaster completed remote builds in B157857: Diff 420341.Apr 4 2022, 5:39 PM
kito-cheng accepted this revision.Apr 4 2022, 8:34 PM
Closed by commit rG4875ff1dc90b: [RISCV] Remove redundant enabling of IAS for Clang, NFC (authored by brad). · Explain WhyApr 4 2022, 8:45 PM
This revision was automatically updated to reflect the committed changes.
brad added a commit: rG4875ff1dc90b: [RISCV] Remove redundant enabling of IAS for Clang, NFC.

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
1 line

Diff 420373

clang/lib/Driver/ToolChains/RISCVToolchain.h

Show All 16 Lines
namespace toolchains { namespace toolchains {
class LLVM_LIBRARY_VISIBILITY RISCVToolChain : public Generic_ELF { class LLVM_LIBRARY_VISIBILITY RISCVToolChain : public Generic_ELF {
public: public:
RISCVToolChain(const Driver &D, const llvm::Triple &Triple, RISCVToolChain(const Driver &D, const llvm::Triple &Triple,
const llvm::opt::ArgList &Args); const llvm::opt::ArgList &Args);
static bool hasGCCToolchain(const Driver &D, const llvm::opt::ArgList &Args); static bool hasGCCToolchain(const Driver &D, const llvm::opt::ArgList &Args);
bool IsIntegratedAssemblerDefault() const override { return true; }
void addClangTargetOptions(const llvm::opt::ArgList &DriverArgs, void addClangTargetOptions(const llvm::opt::ArgList &DriverArgs,
llvm::opt::ArgStringList &CC1Args, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind) const override; Action::OffloadKind) const override;
RuntimeLibType GetDefaultRuntimeLibType() const override; RuntimeLibType GetDefaultRuntimeLibType() const override;
UnwindLibType UnwindLibType
GetUnwindLibType(const llvm::opt::ArgList &Args) const override; GetUnwindLibType(const llvm::opt::ArgList &Args) const override;
void void
AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs, AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs,
Show All 33 Lines