Corrected A Command

[ps-19]

Summary

In https://github.com/llvm/llvm-project/blob/main/clang/test/CodeGen/c-unicode.c

I can not find command RUN: %clang --target=x86_64--linug-gnu -S %s -o - | FileCheck %s -check-prefix=ALLOWED .
So corrected it.

As given here https://unix.stackexchange.com/questions/206410/why-gcc-show-unknown-in-target-x86-64-unknown-linux-gnu-in-arch-linux#:~:text=lto%2Dwrapper%0A%20Target%3A-,x86_64%2Dubuntu%2Dlinux%2Dgnu,-linux

[ps-19]

I seriously can not understand why x64_Debian build if failing for every patch.

clang/test/CodeGen/c-unicode.c

5

Comment Line No: 5 is // ALLOWED: "곎ss": i think "곎ss" in istake here, according to google it is written in korean and i can not understand it's meaning, but it should be made more concise and readable for more user.

[ps-19]

In D122965#3424348, @ps-19 wrote:

I seriously can not understand why x64_Debian build if failing for every patch.

I have ran clang-format command for every patch even multiple times.

[smeenai]

Thanks for the typo fix!

clang/test/CodeGen/c-unicode.c

5

Given that the test is called c-unicode.c, I imagine it's intentional.

mypatch.patch

1

This seems like an unrelated change; can you remove it from this patch please?

[ps-19]

Can anyone please review the patch?

clang/test/CodeGen/c-unicode.c

5

Yes i too was thinking the same.

[aaron.ballman]

In D122965#3426403, @ps-19 wrote:

Can anyone please review the patch?

FYI: please only ping the patch after about a week has gone by with no review (https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted). Reviewers get to reviews as we're able to, but it's quite common for there to be a few days between reviews.

That said, the changes here LGTM (though I can't fathom why this was a CodeGen test to begin with -- it looks like it should have been a Parser or Sema test and using -verify)

[aaron.ballman]

In D122965#3426412, @aaron.ballman wrote:

In D122965#3426403, @ps-19 wrote:

Can anyone please review the patch?

FYI: please only ping the patch after about a week has gone by with no review (https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted). Reviewers get to reviews as we're able to, but it's quite common for there to be a few days between reviews.

That said, the changes here LGTM (though I can't fathom why this was a CodeGen test to begin with -- it looks like it should have been a Parser or Sema test and using -verify)

Oops, forgot to ask -- what name and email address would you like for patch attribution?

[ps-19]

Priyansh Singh
[e-mail]

[aaron.ballman]

In D122965#3426446, @ps-19 wrote:

Priyansh Singh
[e-mail]

Thanks! I've landed on your behalf in aa19500a4c3a66058078f88b3a7dd7a9ad30be12.

clang/test/CodeGen/c-unicode.c

 // REQUIRES: x86-registered-target
-// RUN: %clang --target=x86_64--linug-gnu -S %s -o - | FileCheck %s -check-prefix=ALLOWED
+// RUN: %clang --target=x86_64--linux-gnu -S %s -o - | FileCheck %s -check-prefix=ALLOWED
 // RUN: not %clang --target=x86_64--linux-gnu -std=c89 -S %s -o - 2>&1 | FileCheck %s -check-prefix=DENIED
 int \uaccess = 0;
 // ALLOWED: "곎ss":
 // ALLOWED-NOT: "\uaccess":
 // DENIED: warning: universal character names are only valid in C99 or C++; treating as '\' followed by identifier [-Wunicode]
 // DENIED: error: expected identifier or '('

mypatch.patch

+diff --git a/llvm/utils/vim/indent/llvm.vim b/llvm/utils/vim/indent/llvm.vim
+index d1d8c83d1186..75ee9ef485d4 100644
+--- a/llvm/utils/vim/indent/llvm.vim
++++ b/llvm/utils/vim/indent/llvm.vim
+@@ -52,7 +52,7 @@ function! GetLLVMIndent()
+ 
+   " Find a non-blank not-completely commented line above the current line.
+   let prev_lnum = prevnonblank(v:lnum - 1)
+-  while prev_lnum > 0 && synIDattr(synID(prev_lnum, indent(prev_lnum)+1, 0), "name") =? "string\|comment"
++  while prev_lnum > 0 && synIDattr(synID(prev_lnum, indent(prev_lnum)+1, 0), "name") =~? "string\|comment"
+     let prev_lnum = prevnonblank(prev_lnum-1)
+   endwhile
+   " Hit the start of the file, use zero indent.