Page MenuHomePhabricator

ps-19 (Priyansh Singh)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2022, 11:44 AM (13 w, 6 d)

Recent Activity

Fri, Jun 10

ps-19 abandoned D122814: Functionality Added to CMAKE.
Fri, Jun 10, 7:23 AM · Restricted Project, Restricted Project

Apr 9 2022

ps-19 abandoned D123384: Removed Expected Compilation Error.
Apr 9 2022, 10:14 AM · Restricted Project, Restricted Project
ps-19 added a comment to D123384: Removed Expected Compilation Error.

I too have a doubt that cstdlib may have been added through some another header file, but i was not sure about it.

Apr 9 2022, 12:53 AM · Restricted Project, Restricted Project

Apr 8 2022

ps-19 retitled D123382: Improved Inclusivity from Docs to Improved Inclusivity.
Apr 8 2022, 10:16 AM · Restricted Project, Restricted Project
ps-19 updated the summary of D123384: Removed Expected Compilation Error.
Apr 8 2022, 10:16 AM · Restricted Project, Restricted Project
ps-19 updated the summary of D123407: File Extension.
Apr 8 2022, 10:15 AM · Restricted Project, Restricted Project
ps-19 requested review of D123407: File Extension.
Apr 8 2022, 10:14 AM · Restricted Project, Restricted Project
ps-19 requested review of D123384: Removed Expected Compilation Error.
Apr 8 2022, 5:33 AM · Restricted Project, Restricted Project
ps-19 requested review of D123382: Improved Inclusivity.
Apr 8 2022, 5:09 AM · Restricted Project, Restricted Project

Apr 6 2022

ps-19 updated the diff for D122990: Added new file & improved inclusivity.
Apr 6 2022, 11:25 PM · Restricted Project, Restricted Project
ps-19 added a comment to D122990: Added new file & improved inclusivity.

Is their anything wrong in this patch?

Apr 6 2022, 1:14 PM · Restricted Project, Restricted Project

Apr 5 2022

ps-19 updated the diff for D122990: Added new file & improved inclusivity.

Minor Changes

Apr 5 2022, 1:24 PM · Restricted Project, Restricted Project
ps-19 updated the diff for D122990: Added new file & improved inclusivity.

Minor Changes

Apr 5 2022, 1:18 PM · Restricted Project, Restricted Project
ps-19 updated the diff for D122990: Added new file & improved inclusivity.
Apr 5 2022, 9:03 AM · Restricted Project, Restricted Project
ps-19 updated the diff for D122990: Added new file & improved inclusivity.
Apr 5 2022, 8:45 AM · Restricted Project, Restricted Project
ps-19 updated the diff for D122990: Added new file & improved inclusivity.
Apr 5 2022, 8:40 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122990: Added new file & improved inclusivity.

Most of the changes LGTM, the only concerns I have left are around the READMEs. One thing we could do is split the question about what to do with READMEs off into a separate patch so that we can land the straightforward fixes now, if you'd like.

Apr 5 2022, 5:32 AM · Restricted Project, Restricted Project

Apr 4 2022

ps-19 updated the diff for D122990: Added new file & improved inclusivity.
Apr 4 2022, 12:57 PM · Restricted Project, Restricted Project
ps-19 added a comment to D122965: Corrected A Command.

Priyansh Singh
priyansh.singh100@gmail.com

Apr 4 2022, 8:28 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122965: Corrected A Command.

Can anyone please review the patch?

Apr 4 2022, 8:16 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122990: Added new file & improved inclusivity.

Can anyone please review the differential.

Apr 4 2022, 8:13 AM · Restricted Project, Restricted Project
ps-19 updated the diff for D122990: Added new file & improved inclusivity.
Apr 4 2022, 3:38 AM · Restricted Project, Restricted Project

Apr 3 2022

ps-19 updated the diff for D122965: Corrected A Command.
Apr 3 2022, 11:11 PM · Restricted Project, Restricted Project
ps-19 updated the diff for D122990: Added new file & improved inclusivity.
Apr 3 2022, 10:22 AM · Restricted Project, Restricted Project
ps-19 updated the diff for D122990: Added new file & improved inclusivity.

All mentioned points satisfies now.
@jpienaar

Apr 3 2022, 8:04 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122990: Added new file & improved inclusivity.
Apr 3 2022, 5:17 AM · Restricted Project, Restricted Project
ps-19 retitled D122916: Vim Command from Vim Syntax Error to Vim Command.
Apr 3 2022, 5:16 AM · Restricted Project, Restricted Project
ps-19 updated the diff for D122990: Added new file & improved inclusivity.
Apr 3 2022, 5:11 AM · Restricted Project, Restricted Project
ps-19 requested review of D122990: Added new file & improved inclusivity.
Apr 3 2022, 12:24 AM · Restricted Project, Restricted Project

Apr 2 2022

ps-19 added a comment to D122965: Corrected A Command.

I seriously can not understand why x64_Debian build if failing for every patch.

Apr 2 2022, 1:04 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122965: Corrected A Command.

I seriously can not understand why x64_Debian build if failing for every patch.

Apr 2 2022, 1:04 AM · Restricted Project, Restricted Project
ps-19 retitled D122965: Corrected A Command from Correct Command to Corrected A Command.
Apr 2 2022, 12:09 AM · Restricted Project, Restricted Project

Apr 1 2022

ps-19 requested review of D122965: Corrected A Command.
Apr 1 2022, 11:26 PM · Restricted Project, Restricted Project
ps-19 requested review of D122916: Vim Command.
Apr 1 2022, 9:43 AM · Restricted Project, Restricted Project
ps-19 abandoned D122871: Clang-Formatting.

Closed as:

  1. Formating test file causes build to fail.
  2. Formatting of whole page is not accpeted in LLVM as it created problem future with commands like git blame .
Apr 1 2022, 5:59 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122871: Clang-Formatting.

Pardon, it was my mistake i didn't see that the file i was amending was actually a test file i just search "switch" statement in my script.

Apr 1 2022, 5:50 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122814: Functionality Added to CMAKE.

i have seen some cases in repos where no build variants are found and that creates error in building at some moment. It's good standard practice to include NONE type even we don't need this time, else everything is fine for now, i may close the patch for now.

Apr 1 2022, 5:48 AM · Restricted Project, Restricted Project
ps-19 updated the summary of D122871: Clang-Formatting.
Apr 1 2022, 4:50 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122871: Clang-Formatting.

okay now i understand the issue completely.
If i just mentioned that i am formatting a test file it would be correct then according to my patch.

Apr 1 2022, 4:50 AM · Restricted Project, Restricted Project

Mar 31 2022

ps-19 added a comment to D122871: Clang-Formatting.
Mar 31 2022, 11:34 PM · Restricted Project, Restricted Project
ps-19 requested review of D122871: Clang-Formatting.
Mar 31 2022, 11:17 PM · Restricted Project, Restricted Project
ps-19 added a comment to D122814: Functionality Added to CMAKE.

Can any one please specify the issue in building? I am not being able to understand.

Mar 31 2022, 10:12 PM · Restricted Project, Restricted Project
ps-19 updated the diff for D122814: Functionality Added to CMAKE.

Formatted again using Clang-Format.

Mar 31 2022, 1:18 PM · Restricted Project, Restricted Project
ps-19 requested review of D122814: Functionality Added to CMAKE.
Mar 31 2022, 6:58 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122719: Improved Documentation Inclusivity.

Sir,
I don't have word to say thanks to you for helping. I am blessed to meet you in this repository else i would have switched to some other repository. My head is aching constantly from morning.
Thank you.

Mar 31 2022, 4:35 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122719: Improved Documentation Inclusivity.

Name: Priyansh Singh
Email: priyansh.singh100@gmail.com

Mar 31 2022, 4:30 AM · Restricted Project, Restricted Project
ps-19 updated the diff for D122719: Improved Documentation Inclusivity.

Clang Formatting Checked

Mar 31 2022, 1:13 AM · Restricted Project, Restricted Project

Mar 30 2022

ps-19 added a comment to D122719: Improved Documentation Inclusivity.

sir can you please merge it now. I am going to work on issue#53178 .

Mar 30 2022, 9:22 AM · Restricted Project, Restricted Project
ps-19 updated subscribers of D122727: Improved Documentation Inclusivity.

@xbolva00 can you please review https://reviews.llvm.org/D122719 patch. Is their any thing wrong in it?

Mar 30 2022, 8:58 AM · Restricted Project, Restricted Project
ps-19 abandoned D122727: Improved Documentation Inclusivity.

A patch which addresses same issue has already been submitted https://reviews.llvm.org/D122719 .

Mar 30 2022, 7:56 AM · Restricted Project, Restricted Project
ps-19 updated the diff for D122719: Improved Documentation Inclusivity.

Last Change.

Mar 30 2022, 6:20 AM · Restricted Project, Restricted Project
ps-19 reclaimed D122719: Improved Documentation Inclusivity.
Mar 30 2022, 6:20 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122719: Improved Documentation Inclusivity.

Instead of https://reviews.llvm.org/D122727 you could just continue here with new patch revision. It would be better for you to learn things properly, instead of doing easy but incorrect ways how to solve some issues. :)

If you want learn more about phabricator, you can create new empty patch review without reviewers where you can play and learn things.

Mar 30 2022, 6:18 AM · Restricted Project, Restricted Project
ps-19 requested review of D122727: Improved Documentation Inclusivity.
Mar 30 2022, 5:30 AM · Restricted Project, Restricted Project
ps-19 abandoned D122719: Improved Documentation Inclusivity.
Mar 30 2022, 5:26 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122719: Improved Documentation Inclusivity.

can anyone help me to understand why build is failing?

Mar 30 2022, 5:08 AM · Restricted Project, Restricted Project
ps-19 updated the diff for D122719: Improved Documentation Inclusivity.

Minor Changes.

Mar 30 2022, 4:57 AM · Restricted Project, Restricted Project
ps-19 updated the diff for D122719: Improved Documentation Inclusivity.

Minor changes.

Mar 30 2022, 4:54 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122719: Improved Documentation Inclusivity.

what should i do now? Close this patch and resend patch as a separate file again. I seriously can not understand how to edit patch?

Once you've made your changes and put them in a new patch, you can update this review with the new patch content by clicking the Update Diff link on the upper-right of this review (to the right of the Details section).

(We'll see if the picture I uploaded works or not, but it circles the button you're looking for.)

Mar 30 2022, 4:42 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122719: Improved Documentation Inclusivity.

Done Now!!

Mar 30 2022, 4:40 AM · Restricted Project, Restricted Project
ps-19 updated the diff for D122719: Improved Documentation Inclusivity.

Removed a grammatical mistake.

Mar 30 2022, 4:40 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122719: Improved Documentation Inclusivity.
Mar 30 2022, 4:30 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122719: Improved Documentation Inclusivity.
Mar 30 2022, 4:14 AM · Restricted Project, Restricted Project
ps-19 updated the summary of D122719: Improved Documentation Inclusivity.
Mar 30 2022, 4:03 AM · Restricted Project, Restricted Project
ps-19 added a comment to D122719: Improved Documentation Inclusivity.

My First Contribution to LLVM please merge the patch.

Mar 30 2022, 3:58 AM · Restricted Project, Restricted Project
ps-19 requested review of D122719: Improved Documentation Inclusivity.
Mar 30 2022, 3:57 AM · Restricted Project, Restricted Project

Mar 29 2022

Herald added a project to D72374: [docs] use git diff instead of git format-patch: Restricted Project.
Mar 29 2022, 11:24 AM · Restricted Project, Restricted Project