I too have a doubt that cstdlib may have been added through some another header file, but i was not sure about it.

Is their anything wrong in this patch?

Minor Changes

Minor Changes

In D122990#3429141, @aaron.ballman wrote:

Most of the changes LGTM, the only concerns I have left are around the READMEs. One thing we could do is split the question about what to do with READMEs off into a separate patch so that we can land the straightforward fixes now, if you'd like.

Priyansh Singh
priyansh.singh100@gmail.com

Can anyone please review the patch?

Can anyone please review the differential.

All mentioned points satisfies now.
@jpienaar

In D122965#3424348, @ps-19 wrote:

I seriously can not understand why x64_Debian build if failing for every patch.

I seriously can not understand why x64_Debian build if failing for every patch.

Closed as:

1. Formating test file causes build to fail.
2. Formatting of whole page is not accpeted in LLVM as it created problem future with commands like git blame .

Pardon, it was my mistake i didn't see that the file i was amending was actually a test file i just search "switch" statement in my script.

i have seen some cases in repos where no build variants are found and that creates error in building at some moment. It's good standard practice to include NONE type even we don't need this time, else everything is fine for now, i may close the patch for now.

okay now i understand the issue completely.
If i just mentioned that i am formatting a test file it would be correct then according to my patch.

Can any one please specify the issue in building? I am not being able to understand.

Formatted again using Clang-Format.

Sir,
I don't have word to say thanks to you for helping. I am blessed to meet you in this repository else i would have switched to some other repository. My head is aching constantly from morning.
Thank you.

Name: Priyansh Singh
Email: priyansh.singh100@gmail.com

Clang Formatting Checked

sir can you please merge it now. I am going to work on issue#53178 .

@xbolva00 can you please review https://reviews.llvm.org/D122719 patch. Is their any thing wrong in it?

A patch which addresses same issue has already been submitted https://reviews.llvm.org/D122719 .

Last Change.

In D122719#3416495, @xbolva00 wrote:

Instead of https://reviews.llvm.org/D122727 you could just continue here with new patch revision. It would be better for you to learn things properly, instead of doing easy but incorrect ways how to solve some issues. :)

If you want learn more about phabricator, you can create new empty patch review without reviewers where you can play and learn things.

can anyone help me to understand why build is failing?

Minor Changes.

Minor changes.

In D122719#3416324, @aaron.ballman wrote:

In D122719#3416297, @ps-19 wrote:

what should i do now? Close this patch and resend patch as a separate file again. I seriously can not understand how to edit patch?

Once you've made your changes and put them in a new patch, you can update this review with the new patch content by clicking the Update Diff link on the upper-right of this review (to the right of the Details section).

(We'll see if the picture I uploaded works or not, but it circles the button you're looking for.)

Done Now!!

Removed a grammatical mistake.

My First Contribution to LLVM please merge the patch.