Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | ||
---|---|---|
635 | Surely you don't need both of these lines - all operands are vectors or all are scalars. |
Comment Actions
LGTM, though it would be even better if we had some *.ll tests for these so we could see how it affects codegen.
llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-sadde.mir | ||
---|---|---|
53 | I'm a bit surprised we don't end up with s32 = G_ZEXT s1. Do we have an optimization that puts this back together? |
Surely you don't need both of these lines - all operands are vectors or all are scalars.