This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][GlobalISel] Add end to end IR tests for add/sub with overflow
ClosedPublic

Authored by abinavpp on Mar 31 2022, 7:37 AM.

Diff Detail

Event Timeline

abinavpp created this revision.Mar 31 2022, 7:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2022, 7:37 AM
Herald added subscribers: kerbowa, t-tye, tpr and 5 others. · View Herald Transcript
abinavpp requested review of this revision.Mar 31 2022, 7:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2022, 7:37 AM
arsenm added inline comments.Mar 31 2022, 7:39 AM
llvm/test/CodeGen/AMDGPU/GlobalISel/addo.ll
7

Add v_ prefix to these tests.

Also a few with mixed VGPR and SGPR inputs

592

Can you also test i8/i16 and then some odd sizes?

abinavpp updated this revision to Diff 419489.Mar 31 2022, 8:59 AM

Addressed review comments

arsenm accepted this revision.Mar 31 2022, 9:00 AM
This revision is now accepted and ready to land.Mar 31 2022, 9:00 AM
abinavpp marked 2 inline comments as done.Mar 31 2022, 9:00 AM
This revision was landed with ongoing or failed builds.Mar 31 2022, 9:17 AM
This revision was automatically updated to reflect the committed changes.