This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Add guard in LowerSELECT_CC for ppcf128
AbandonedPublic

Authored by tingwang on Mar 24 2022, 10:52 PM.

Details

Reviewers
jsji
nemanjai
shchenz
Group Reviewers
Restricted Project
Summary

LowerSELECT_CC can be used to lower intrinsics for example __builtin_max. In the long double case, we need to add this check so that ppcf128 does not wrongly pickup PPCISD::XSMAXC.

Diff Detail

Event Timeline

tingwang created this revision.Mar 24 2022, 10:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 10:52 PM
tingwang requested review of this revision.Mar 24 2022, 10:52 PM
lkail added a subscriber: lkail.Mar 24 2022, 10:57 PM

Please also add tests.

Please also add tests.

This does not affect existing tests. The case to show is __builtin_max which I'm still working on, and will coming out shortly. I'm not sure if we can forge a test case to show its effectiveness in current code base.

tingwang abandoned this revision.Mar 28 2022, 4:41 AM

Not required