Page MenuHomePhabricator

[AMDGPU] Ensure return address is save/restored if clobbered or when function has calls
ClosedPublic

Authored by RamNalamothu on Mar 3 2022, 10:47 AM.

Details

Summary

This test is to make sure the return address registers, if clobbered in the
function or when the function has calls, are save/restored irrespective of
whether the IPRA is enabled/disabled.

This test is found to be not save/restore the return address registers, when
clobbered in the function, with the corresponding downstream changes of D114652.

The test could not be reduced further as the register allocator needs enough
register pressure so that it allocates the return address registers as well.

Diff Detail

Event Timeline

RamNalamothu created this revision.Mar 3 2022, 10:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 10:47 AM
RamNalamothu requested review of this revision.Mar 3 2022, 10:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 10:47 AM
arsenm accepted this revision.Mar 7 2022, 6:52 AM

An artificial test with high pressure would be more reliable long term. Branches on constants could be fragile

This revision is now accepted and ready to land.Mar 7 2022, 6:52 AM

An artificial test with high pressure would be more reliable long term. Branches on constants could be fragile

I will make a note of this in the test so that it can be updated later and will proceed with the test in its current form to unblock my work. Thank you.

This revision was landed with ongoing or failed builds.Mar 7 2022, 8:31 AM
This revision was automatically updated to reflect the committed changes.