Details
Diff Detail
Unit Tests
Event Timeline
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
4263 | This code looks odd because from the naming alone I would expect isGFX90A and isGFX940 to be mutually exclusive. |
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
4263 | This is true, but this is all across the MC layer and many places above it, not just for this target. It can use a separate and massive cleanup, not simply changing this line. |
Other than a TODO comment, LGTM, thanks
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
4263 | Can we add a TODO mentioning that this needs a cleanup? |
clang-format: please reformat the code