This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Update tests to include opencl-c-base.h
ClosedPublic

Authored by svenvh on Feb 24 2022, 3:44 AM.

Details

Summary

After D120254 some clang-tidy tests started failing on release builds.

clang-tidy has been using the -fdeclare-opencl-builtins functionality
since this became the default in clang, so there is no need to include
opencl-c.h.

Diff Detail

Event Timeline

svenvh created this revision.Feb 24 2022, 3:44 AM
svenvh requested review of this revision.Feb 24 2022, 3:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2022, 3:44 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
svenvh updated this revision to Diff 411106.Feb 24 2022, 6:22 AM
svenvh edited the summary of this revision. (Show Details)
svenvh added reviewers: Anastasia, ffrankies.

After a bit of digging I realized we don't need the explicit include at all anymore.

Eugene.Zelenko set the repository for this revision to rG LLVM Github Monorepo.

Since this is a simple test update I'll commit this now (before code review), to get affected CI back to green. Please let me know if there are any post-commit concerns.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2022, 8:29 AM
This revision was automatically updated to reflect the committed changes.