Page MenuHomePhabricator

ffrankies (Frank Derry Wanye)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2019, 10:50 AM (95 w, 3 d)

Recent Activity

May 6 2021

ffrankies added a comment to D70094: [clang-tidy] new altera ID dependent backward branch check.

@aaron.ballman Thank you! As far as I'm aware, this is the last check that we are planning to submit, so if I do get commit access now it's likely to be unused. However, if that does change, then yes I would be interested in obtaining commit access. For now, can you please commit this on my behalf? My github username is ffrankies.

May 6 2021, 12:39 PM · Restricted Project, Restricted Project

May 3 2021

ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.

Addressed comment by @aaron.ballman and the Pre-update checks linter

  • Removed calls to std::move for llvm::Twine::str() object in IdDependencyRecord constructors
May 3 2021, 10:58 AM · Restricted Project, Restricted Project

May 2 2021

ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.

Removed unused import statements from IdDependentBackwardBranch.cpp

May 2 2021, 2:42 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.

Addressed comments by @aaron.ballman

May 2 2021, 2:29 PM · Restricted Project, Restricted Project

Apr 29 2021

ffrankies added a comment to D70094: [clang-tidy] new altera ID dependent backward branch check.

@Eugene.Zelenko @aaron.ballman Are there any more changes that need to be made to this check or comments that need to be addressed?

Apr 29 2021, 11:47 AM · Restricted Project, Restricted Project

Apr 16 2021

ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.

Removed *- C++ -* from IdDependentBackwardBranchCheck.cpp file-level comment.

Apr 16 2021, 9:58 AM · Restricted Project, Restricted Project

Apr 9 2021

ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.

Addressed comments by @Eugene.Zelenko and the automated build bot

  • Fixed header comments and include guard style
  • Removed unnecessary comments in getLoopType()
  • changed IDDependencyRecord() {} to IDDependencyRecord() = default;
Apr 9 2021, 10:31 AM · Restricted Project, Restricted Project

Apr 4 2021

ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.
  • Addressed comments from the automated pre-merge checks
  • Moved link to external documentation to the end of clang-tools-extra/docs/clang-tidy/checks/altera-id-dependent-backward-branch.rst as requested by @Eugene.Zelenko
Apr 4 2021, 10:09 PM · Restricted Project, Restricted Project

Apr 2 2021

ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.
  • Rebased on top of latest changes in main branch
  • The diagnostic that identifies the code location where an ID-dependent variable/field is assigned has been changed from a warning to a note
  • Changes addressing code style
Apr 2 2021, 10:05 AM · Restricted Project, Restricted Project

Mar 22 2021

ffrankies added a comment to D72235: [clang-tidy] new altera unroll loops check.

Thank you very much!

Mar 22 2021, 10:36 AM · Restricted Project, Restricted Project
ffrankies added a comment to D72235: [clang-tidy] new altera unroll loops check.

@aaron.ballman If there are no more changes, can you please commit this on my behalf? My github username is ffrankies.

Mar 22 2021, 8:58 AM · Restricted Project, Restricted Project
ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.

Implemented changes requested by @aaron.ballman

Mar 22 2021, 8:54 AM · Restricted Project, Restricted Project

Mar 8 2021

ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.
  • Ran git-clang-format HEAD^
  • Addressed comments automatically added by the Lint: Pre-merge Checks
Mar 8 2021, 9:38 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.

Rebased with the latest main branch to fix patch application errors.

Mar 8 2021, 11:35 AM · Restricted Project, Restricted Project

Mar 7 2021

ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.
  • Removed unnecessary braces.
  • Simplified boolean return statements.
Mar 7 2021, 10:02 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.
  • Surrounded language constructs with double back ticks in clang-tools-extra/docs/clang-tidy/checks/altera-unroll-loops.rst.
  • Removed trailing whitespace.
  • Added single quotes around #pragma unrolls in diagnostics.
  • Added full stops to the comments that didn't have them in clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp
Mar 7 2021, 9:40 PM · Restricted Project, Restricted Project

Mar 5 2021

ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.
  • Added support for CXXForRangeStmt loops
  • Added support for different for loop increments (++, --, +=, -=, *=, \=)
    • Depending on the exit condition, the calculations for the number of Iterations may be off by 1, but that should not be an issue performance-wise since the threshold for a "large" number of iterations is likely to be arbitrary.
    • If any other increment is used in the increment part of the for loop, we recommend partial unrolling.
  • Changed the way while and do..while loops are handled: because the loop variable is changed within the loop body and it is untrivial to determine what is happening to it, we now emit a Note diagnostic (instead of warning) recommending partial unrolling if a while or do..while loop is fully unrolled.
  • Added tests for the above
  • Documented the above caveats in clang-tools-extra/docs/clang-tidy/checks/altera-unroll-loops.rst
Mar 5 2021, 10:54 AM · Restricted Project, Restricted Project

Dec 21 2020

ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.
  • Addressed comments from @njames93
  • Rebased with latest master branch to make sure there are no merge issues with the latest committed altera check
Dec 21 2020, 12:11 PM · Restricted Project, Restricted Project

Dec 18 2020

ffrankies added a comment to D72241: [clang-tidy] new altera single work item barrier check.

@aaron.ballman @njames93 thanks for testing this out, the feedback, and the commit!

Dec 18 2020, 8:11 AM · Restricted Project, Restricted Project

Dec 17 2020

ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.
  • removed unnecessary comment
Dec 17 2020, 7:47 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.
  • Rebased with master branch
  • Diagnostics are re-worded so they're not complete sentences
Dec 17 2020, 7:44 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D72241: [clang-tidy] new altera single work item barrier check.

@aaron.ballman hmm, that is strange. I've rebased the patch and updated the diff, let me know if this one doesn't work either or there's something else you'd like me to try. Thanks! For what it's worth it's building just fine and passing the clang-tools tests on my end.

Dec 17 2020, 6:09 PM · Restricted Project, Restricted Project

Dec 11 2020

ffrankies added a comment to D72241: [clang-tidy] new altera single work item barrier check.

@aaron.ballman Thank you! If there are no further comments, could you please commit this on my behalf? My GitHub username is ffrankies.

Dec 11 2020, 11:40 AM · Restricted Project, Restricted Project

Dec 4 2020

ffrankies updated the diff for D72241: [clang-tidy] new altera single work item barrier check.

Implemented changes requested by @aaron.ballman

  • using hasAnyName() instead of multiple hasName() calls in the matcher
  • switched to a combination of hasAttr<>() and getAttr<>() to remove need for casting and looping over all attributes (did not use specific_attrs<>() because there should only be one ReqdWorkGroupSizeAttr per function)
  • re-phrased diagnostic messages
  • added all 4 ID functions to the documentation
  • removed the update to BUILD.gn
Dec 4 2020, 10:05 AM · Restricted Project, Restricted Project

Nov 7 2020

ffrankies updated the diff for D72218: [clang-tidy] new altera kernel name restriction check.

Moved test files KERNEL.cl, VHDL.cl and vERILOG.cl to the uppercase subdirectory to prevent filename clashes in some environments.

Nov 7 2020, 4:26 PM · Restricted Project, Restricted Project

Oct 30 2020

ffrankies added a comment to D72218: [clang-tidy] new altera kernel name restriction check.

@aaron.ballman Can you please commit this on my behalf? My github username is ffrankies.

Oct 30 2020, 5:35 AM · Restricted Project, Restricted Project
ffrankies updated the diff for D72218: [clang-tidy] new altera kernel name restriction check.

Implemented changes requested by @aaron.ballman

Oct 30 2020, 5:29 AM · Restricted Project, Restricted Project

Oct 16 2020

ffrankies updated the diff for D72218: [clang-tidy] new altera kernel name restriction check.

Addressed comments by @aaron.ballman regarding the diagnostic warning.

Oct 16 2020, 7:02 AM · Restricted Project, Restricted Project

Oct 1 2020

ffrankies updated the diff for D72241: [clang-tidy] new altera single work item barrier check.
  • Rebased code and fixed merge conflicts with D66564
  • Added SingleWorkItemBarrierCheck.cpp to BUILD.gn
Oct 1 2020, 5:14 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D72218: [clang-tidy] new altera kernel name restriction check.

Addressed changes requested by @Eugene.Zelenko and @aaron.ballman

Oct 1 2020, 5:08 PM · Restricted Project, Restricted Project

Sep 24 2020

ffrankies removed projects from D72218: [clang-tidy] new altera kernel name restriction check: Restricted Project, Restricted Project.
Sep 24 2020, 7:11 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D72218: [clang-tidy] new altera kernel name restriction check.
  • Rebased code and fixed merge conflicts with D66564
  • Added KernelNameRestrictionCheck.cpp to BUILD.gn
Sep 24 2020, 7:10 PM · Restricted Project, Restricted Project

Apr 1 2020

ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.
Apr 1 2020, 2:04 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D72218: [clang-tidy] new altera kernel name restriction check.
Apr 1 2020, 2:04 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D72241: [clang-tidy] new altera single work item barrier check.
Apr 1 2020, 2:04 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.

Addressed comments by @Eugene.Zelenko

Apr 1 2020, 1:41 PM · Restricted Project, Restricted Project

Mar 4 2020

ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.

@Eugene.Zelenko It turns out we were using an old mirror of the clang-tools-extra repository, that no longer seems to be updated. I switched to the llvm-project repo, and updated the documentation accordingly (some of the formatting is different now). Let me know if I missed anything - if not, I will be switching the other checks over to the llvm-project repo as well over the coming weeks.

Mar 4 2020, 3:11 PM · Restricted Project, Restricted Project

Feb 27 2020

ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.

Addressed comments by @Eugene.Zelenko

Feb 27 2020, 10:21 AM · Restricted Project, Restricted Project

Feb 11 2020

ffrankies updated the diff for D72218: [clang-tidy] new altera kernel name restriction check.

Implemented changes requested by @Eugene.Zelenko:

Feb 11 2020, 12:15 PM · Restricted Project, Restricted Project

Feb 10 2020

ffrankies updated the diff for D72241: [clang-tidy] new altera single work item barrier check.

Implemented requested changes by @Eugene.Zelenko

Feb 10 2020, 7:42 PM · Restricted Project, Restricted Project

Jan 11 2020

ffrankies added a comment to D72239: [clang-tidy] new opencl recursion not supported check.

The other recursion check seems more sophisticated. What is your take on it? Would you consider it better as well, what is your opinion on it?

Jan 11 2020, 3:22 PM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2020

ffrankies created D72241: [clang-tidy] new altera single work item barrier check.
Jan 5 2020, 7:39 PM · Restricted Project, Restricted Project
ffrankies created D72239: [clang-tidy] new opencl recursion not supported check.
Jan 5 2020, 5:39 PM · Restricted Project, Restricted Project, Restricted Project
ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.
Jan 5 2020, 4:16 PM · Restricted Project, Restricted Project
ffrankies updated the diff for D72235: [clang-tidy] new altera unroll loops check.
Jan 5 2020, 4:16 PM · Restricted Project, Restricted Project
ffrankies created D72235: [clang-tidy] new altera unroll loops check.
Jan 5 2020, 4:16 PM · Restricted Project, Restricted Project

Jan 4 2020

ffrankies created D72218: [clang-tidy] new altera kernel name restriction check.
Jan 4 2020, 8:10 PM · Restricted Project, Restricted Project

Dec 7 2019

ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.

Addressed @Eugene.Zelenko's comments on use of auto

Dec 7 2019, 8:14 PM · Restricted Project, Restricted Project

Nov 27 2019

ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.

Implemented changes requested by @Eugene.Zelenko

Nov 27 2019, 12:19 PM · Restricted Project, Restricted Project

Nov 11 2019

ffrankies updated the diff for D70094: [clang-tidy] new altera ID dependent backward branch check.
Nov 11 2019, 11:17 AM · Restricted Project, Restricted Project
ffrankies created D70094: [clang-tidy] new altera ID dependent backward branch check.
Nov 11 2019, 10:40 AM · Restricted Project, Restricted Project