This is an archive of the discontinued LLVM Phabricator instance.

[clang] Bump __cpp_constexpr in accordance with P2493R0
Needs ReviewPublic

Authored by MarcusBoay on Feb 24 2022, 12:04 AM.

Details

Reviewers
rsmith
Summary

[clang] Bump __cpp_constexpr in accordance with P2493R0

https://github.com/llvm/llvm-project/issues/54052

Diff Detail

Event Timeline

MarcusBoay requested review of this revision.Feb 24 2022, 12:04 AM
MarcusBoay created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2022, 12:04 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MarcusBoay retitled this revision from bump __cpp_concepts and __cpp_constexpr in accordance with P2493R0 to [clang] Bump __cpp_concepts and __cpp_constexpr in accordance with P2493R0.Feb 24 2022, 12:14 AM
MarcusBoay edited the summary of this revision. (Show Details)
MarcusBoay edited the summary of this revision. (Show Details)
MarcusBoay edited the summary of this revision. (Show Details)Feb 24 2022, 12:18 AM

Thanks for the patch. However, wg21.link/P0848 need to be fully implemented before we can update __cpp_concepts. Could you only modify __cpp_constexpr ? Thanks

Revert __cpp_concepts since it is not fully implemented yet.

MarcusBoay retitled this revision from [clang] Bump __cpp_concepts and __cpp_constexpr in accordance with P2493R0 to [clang] Bump __cpp_constexpr in accordance with P2493R0.Feb 24 2022, 7:35 PM
MarcusBoay edited the summary of this revision. (Show Details)

Thanks for the patch. However, wg21.link/P0848 need to be fully implemented before we can update __cpp_concepts. Could you only modify __cpp_constexpr ? Thanks

Thanks for the info! I reverted the change to __cpp_concepts.