The SPARC and MIPS branching operations have a branch delay slot, 4 more bytes occupied.
Depends on D120381
Differential D120451
[sancov] Add SPARC support for getPreviousInstructionPc. XiaodongLoong on Feb 23 2022, 7:52 PM. Authored by
Details The SPARC and MIPS branching operations have a branch delay slot, 4 more bytes occupied. Depends on D120381
Diff Detail
Event TimelineComment Actions The patch looks sensible, but isn't actually exercised: I ran a sparcv9-sun-solaris2.11 build with it included, which made no difference. However, on closer inspection, the sanitizer_coverage_trace_pc_guard*.cpp tests didn't run: they aren't supported together with ubsan, while asan isn't supported on SPARC due to a clang bug/limitation. That said, the patch is plausible, so LGTM. |