This is an archive of the discontinued LLVM Phabricator instance.

[sancov] Add SPARC support for getPreviousInstructionPc.
ClosedPublic

Authored by XiaodongLoong on Feb 23 2022, 7:52 PM.

Details

Summary

The SPARC and MIPS branching operations have a branch delay slot, 4 more bytes occupied.

Depends on D120381

Diff Detail

Event Timeline

XiaodongLoong created this revision.Feb 23 2022, 7:52 PM
XiaodongLoong requested review of this revision.Feb 23 2022, 7:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2022, 7:52 PM
ro accepted this revision.Feb 25 2022, 4:10 AM

The patch looks sensible, but isn't actually exercised: I ran a sparcv9-sun-solaris2.11 build with it included, which made no difference. However, on closer inspection, the sanitizer_coverage_trace_pc_guard*.cpp tests didn't run: they aren't supported together with ubsan, while asan isn't supported on SPARC due to a clang bug/limitation.

That said, the patch is plausible, so LGTM.

This revision is now accepted and ready to land.Feb 25 2022, 4:10 AM
MaskRay accepted this revision.Feb 26 2022, 12:12 PM
This revision was landed with ongoing or failed builds.Feb 27 2022, 11:11 AM
This revision was automatically updated to reflect the committed changes.