[clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

[SAtacker]

Summary

Depends on D120331

• Ensures that both options -config and -config-file exclude each other

Signed-off-by: Shreyas Atre <[e-mail]>

[Eugene.Zelenko]

clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

239

In other options spaces are place at the end of string. Please also add missing spaces.

[Eugene.Zelenko]

I think will be good to merge these changes to D120331.

[SAtacker]

In D120385#3339440, @Eugene.Zelenko wrote:

I think will be good to merge these changes to D120331.

Thanks for the review. Will land this and make the required changes in the next one.

clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

239

Yes, sure.

[Eugene.Zelenko]

About procedure :-) You could not approve patches yourself, this is task for reviewers. If content of this patch will be merged to another one, just abandon this one.

[SAtacker]

In D120385#3340474, @Eugene.Zelenko wrote:

About procedure :-) You could not approve patches yourself, this is task for reviewers. If content of this patch will be merged to another one, just abandon this one.

Yes sorry for a little chaos from my end. I was struggling to use arcanist and confused the term "land" and the "Add Action" in Phabricator User Interface.
Thank you for the info 👍 .

clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

parser.add_argument('-clang-tidy-binary', metavar='PATH',
                       default='clang-tidy',
                       help='path to clang-tidy binary')
   parser.add_argument('-clang-apply-replacements-binary', metavar='PATH',
                       default='clang-apply-replacements',
                       help='path to clang-apply-replacements binary')
   parser.add_argument('-checks', default=None,
                       help='checks filter, when not specified, use clang-tidy '
                       'default')
-  parser.add_argument('-config', default=None,
+  group = parser.add_mutually_exclusive_group()
+  group.add_argument('-config', default=None,
                       help='Specifies a configuration in YAML/JSON format: '
                       '  -config="{Checks: \'*\', '
                       '                       CheckOptions: [{key: x, '
                       '                                       value: y}]}" '
                       'When the value is empty, clang-tidy will '
                       'attempt to find a file named .clang-tidy for '
                       'each source file in its parent directories.')
-  parser.add_argument('-config-file', default=None,
+  group.add_argument('-config-file', default=None,
                       help='Specify the path of .clang-tidy or custom config'
-                      'file: e.g. -config-file=/some/path/myTidyConfigFile'
+                      ' file: e.g. -config-file=/some/path/myTidyConfigFile'
                       'This option internally works exactly the same way as'
                       '-config option after reading specified config file.'
                       'Use either -config-file or -config, not both.')
   parser.add_argument('-header-filter', default=None,
                       help='regular expression matching the names of the '
                       'headers to output diagnostics from. Diagnostics from '
                       'the main file of each translation unit are always '
                       'displayed.')