This is an archive of the discontinued LLVM Phabricator instance.

[mlir][bufferize][NFC] Rename `comprehensive-function-bufferize` to `one-shot-bufferize`
ClosedPublic

Authored by springerm on Feb 19 2022, 11:20 AM.

Details

Summary

The related functionality is moved over to the bufferization dialect. Test cases are cleaned up a bit.

Depends On D120190

Diff Detail

Event Timeline

springerm created this revision.Feb 19 2022, 11:20 AM
springerm requested review of this revision.Feb 19 2022, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2022, 11:20 AM
pifon2a accepted this revision.Feb 19 2022, 11:50 AM
pifon2a added inline comments.
mlir/include/mlir/Dialect/Bufferization/Transforms/OneShotAnalysis.h
168

did you intend to pass options by value?

This revision is now accepted and ready to land.Feb 19 2022, 11:50 AM
springerm marked an inline comment as done.

rebase

springerm added inline comments.Feb 22 2022, 12:15 AM
mlir/include/mlir/Dialect/Bufferization/Transforms/OneShotAnalysis.h
168

yes i did

This revision was landed with ongoing or failed builds.Feb 22 2022, 12:19 AM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added inline comments.Jul 20 2023, 10:23 PM
mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp
209

This was maybe fine for a test pass, but I really don't think we should do this kind of things in a an actual pass.

For example, I'm currently chasing a bug that I narrowed down to this pass, and doing more A/B comparison it turns out that the output of the pass is identical in both case for my path, but this runPipeline differ. However I have no tool to bisect further!

passes should be small units that composes, a cleanup pipeline inside a pass is a anti-pattern.

Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2023, 10:23 PM
springerm marked an inline comment as done.Jul 21 2023, 1:31 AM
springerm added inline comments.
mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp
209
mlir/test/Dialect/Linalg/comprehensive-module-bufferize.mlir