This is an archive of the discontinued LLVM Phabricator instance.

[Driver][test] Clean up some AIX tests
ClosedPublic

Authored by MaskRay on Feb 8 2022, 8:29 PM.

Details

Summary
  • For -###, -o %t.o is unnecessary if we don't specifically test the output filename.
  • --target= is the canonical spelling. -target is a legacy spelling which unfortunately cannot be removed because there are too many uses.
  • -no-canonical-prefixes uses the dereferenced absolute path for the cc1 command. For most tests "-cc1" is sufficient to identify the command line, no need to specifically test the "clang" command, and -no-canonical-prefixes can removed.
  • --unwindlib= is the preferred spelling. -u is a short option taking a value, which means a -uwindlib= typo cannot be detected.

I recommend that you take a look at linux-cross.cpp. Testing include paths and
library paths in one RUN line is sometimes more readable than having separate
include/library tests.

Having separate RUN lines for misc features like -fdata-sections
(aix-data-sections.c) is wasteful. It may be better testing multiple
options in a single RUN command.

Diff Detail

Event Timeline

MaskRay created this revision.Feb 8 2022, 8:29 PM
MaskRay requested review of this revision.Feb 8 2022, 8:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2022, 8:29 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay updated this revision to Diff 407038.Feb 8 2022, 8:36 PM
MaskRay edited the summary of this revision. (Show Details)

update more

jsji accepted this revision as: jsji.Feb 25 2022, 4:55 PM
jsji edited reviewers, added: Restricted Project; removed: jasonliu, Xiangling_L.
jsji added subscribers: Xiangling_L, jasonliu, jsji.

LGTM. Thanks for cleaning up.
BTW: @jasonliu and @Xiangling_L are no longer working on AIX. #powerpc might get attention from wider group.

This revision is now accepted and ready to land.Feb 25 2022, 4:56 PM

LGTM. Thanks for cleaning up.
BTW: @jasonliu and @Xiangling_L are no longer working on AIX. #powerpc might get attention from wider group.

Thanks!

This revision was landed with ongoing or failed builds.Feb 25 2022, 5:06 PM
This revision was automatically updated to reflect the committed changes.