[cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan

[Orlando]

Summary

And XFAIL debuginfo-tests/llgdb-tests/asan-deque.cpp on !system-darwin.
On non-darwin systems these tests use gdb and this one fails because gdb
doesn't pretty-print std::deque (the elements of the deque are not printed so
the CHECK lines fail).

[Orlando]

+ llvm-commits

[Orlando]

We've now got a native Linux builder in staging where you can see these tests failing: https://lab.llvm.org/staging/#/builders/205/builds/91

[Orlando]

+ Rebase (fix conflicts with D118468)

[StephenTozer]

LGTM apart from the comment below.

cross-project-tests/debuginfo-tests/llgdb-tests/asan-deque.cpp

7

The second expression seems redundant, if !system-darwin && gdb-clang-incompatibility is true then !system-darwin is necessarily also true. Is this meant to be !system-darwin, gdb-clang-incompatibility?

[Orlando]

cross-project-tests/debuginfo-tests/llgdb-tests/asan-deque.cpp

7

It is redundant yes. I figured it would be more obvious to anyone adjusting the test in the future that the second part is still necessary when the tests start passing on !system-darwin. wdyt?

[StephenTozer]

cross-project-tests/debuginfo-tests/llgdb-tests/asan-deque.cpp

7

Seems reasonable, but might be worth expanding the below comment to specify that it applies to the !system-darwin clause, since system-darwin being essentially a proxy for "run with LLDB instead of GDB" here might not be obvious to someone unfamiliar with these tests. Something like "failing on non-darwin (gdb) builds because gdb doesn't pretty-print std::deque" or something along those lines.

[Orlando]

+ Improve comment in test
+ Fix description

cross-project-tests/debuginfo-tests/dexter-tests/asan-deque.cpp

-// REQUIRES: !asan, lldb
+// REQUIRES: !asan, compiler-rt, lldb
 // UNSUPPORTED: system-windows
 //           Zorg configures the ASAN stage2 bots to not build the asan
 //           compiler-rt. Only run this test on non-asanified configurations.
 // UNSUPPORTED: apple-lldb-pre-1000
 
 // XFAIL: lldb
 // lldb-8, even outside of dexter, will sometimes trigger an asan fault in
 // the debugged process and generally freak out.

cross-project-tests/debuginfo-tests/dexter-tests/asan.c

-// REQUIRES: !asan, lldb
+// REQUIRES: !asan, compiler-rt, lldb
 // UNSUPPORTED: system-windows
 //           Zorg configures the ASAN stage2 bots to not build the asan
 //           compiler-rt. Only run this test on non-asanified configurations.
 //
 // RUN: %dexter --fail-lt 1.0 -w \
 // RUN:     --builder 'clang-c' --debugger 'lldb' \
 // RUN:     --cflags "--driver-mode=gcc -O0 -glldb -fblocks -arch x86_64 \
 // RUN:     -fsanitize=address" --ldflags="-fsanitize=address" -- %s

cross-project-tests/debuginfo-tests/dexter-tests/nrvo-string.cpp

 // Purpose:
 //     This ensures that DW_OP_deref is inserted when necessary, such as when
 //     NRVO of a string object occurs in C++.
 //
-// REQUIRES: !asan, lldb
+// REQUIRES: !asan, compiler-rt, lldb
 // UNSUPPORTED: system-windows
 //           Zorg configures the ASAN stage2 bots to not build the asan
 //           compiler-rt. Only run this test on non-asanified configurations.
 //
 // RUN: %dexter --fail-lt 1.0 -w \
 // RUN:     --builder 'clang' --debugger 'lldb' \
 // RUN:     --cflags "-O0 -glldb -fno-exceptions" -- %s
 //

cross-project-tests/debuginfo-tests/llgdb-tests/asan-blocks.c

 // RUN: %clang -fblocks %target_itanium_abi_host_triple -arch x86_64 %s -o %t.out -g -fsanitize=address
 // RUN: %test_debuginfo %s %t.out
 // FIXME: Remove system-darwin when we build BlocksRuntime everywhere.
-// REQUIRES: !asan, system-darwin
+// REQUIRES: !asan, compiler-rt, system-darwin
 //           Zorg configures the ASAN stage2 bots to not build the asan
 //           compiler-rt. Only run this test on non-asanified configurations.
 // XFAIL: !system-darwin && gdb-clang-incompatibility
 
 void b();
 struct S {
   int a[8];
 };

cross-project-tests/debuginfo-tests/llgdb-tests/asan-deque.cpp

 // RUN: %clangxx -arch x86_64 %target_itanium_abi_host_triple -O1 -g %s -o %t.out -fsanitize=address
 // RUN: %test_debuginfo %s %t.out
-// REQUIRES: !asan
+// REQUIRES: !asan, compiler-rt
 //           Zorg configures the ASAN stage2 bots to not build the asan
 //           compiler-rt. Only run this test on non-asanified configurations.
 // UNSUPPORTED: apple-lldb-pre-1000
-// XFAIL: !system-darwin && gdb-clang-incompatibility
+// XFAIL: !system-darwin, (!system-darwin && gdb-clang-incompatibility)
+//        gdb doesn't pretty-print std::deque
 
 #include <deque>
 
 struct A {
   int a;
   A(int a) : a(a) {}
 };
 
 using log_t = std::deque<A>;
 
 static void __attribute__((noinline, optnone)) escape(log_t &log) {
   static volatile log_t *sink;
   sink = &log;
 }
 
 int main() {
   log_t log;
   log.push_back(1234);
   log.push_back(56789);
   escape(log);
-  // DEBUGGER: break 27
+  // DEBUGGER: break 28
   while (!log.empty()) {
     auto record = log.front();
     log.pop_front();
     escape(log);
-    // DEBUGGER: break 32
+    // DEBUGGER: break 33
   }
 }
 
 // DEBUGGER: r
 
-// (at line 27)
+// (at line 28)
 // DEBUGGER: p log
 // CHECK: 1234
 // CHECK: 56789
 
 // DEBUGGER: c
 
-// (at line 32)
+// (at line 33)
 // DEBUGGER: p log
 // CHECK: 56789

cross-project-tests/debuginfo-tests/llgdb-tests/asan.c

 // RUN: %clang -fblocks %target_itanium_abi_host_triple -arch x86_64 %s -o %t.out -g -fsanitize=address
 // RUN: %test_debuginfo %s %t.out
-// REQUIRES: !asan
+// REQUIRES: !asan, compiler-rt
 //           Zorg configures the ASAN stage2 bots to not build the asan
 //           compiler-rt. Only run this test on non-asanified configurations.
 // XFAIL: !system-darwin && gdb-clang-incompatibility
 
 struct S {
   int a[8];
 };
 

cross-project-tests/debuginfo-tests/llgdb-tests/safestack.c

 // RUN: %clang %target_itanium_abi_host_triple -arch x86_64 %s -o %t.out -g -fsanitize=safe-stack
 // RUN: %test_debuginfo %s %t.out
 // UNSUPPORTED: system-darwin
-// REQUIRES: !asan
+// REQUIRES: !asan, compiler-rt
 //           Zorg configures the ASAN stage2 bots to not build the
 //           safestack compiler-rt.  Only run this test on
 //           non-asanified configurations.
 // XFAIL: !system-darwin && gdb-clang-incompatibility
 struct S {
   int a[8];
 };
 

cross-project-tests/lit.cfg.py

 if not hasattr(config, 'clang_src_dir'):
     config.clang_src_dir = ""
 llvm_config.use_clang(required=('clang' in config.llvm_enabled_projects))
 
 if not hasattr(config, 'lld_src_dir'):
     config.lld_src_dir = ""
 llvm_config.use_lld(required=('lld' in config.llvm_enabled_projects))
 
+if 'compiler-rt' in config.llvm_enabled_projects:
+  config.available_features.add('compiler-rt')
+
 if config.llvm_use_sanitizer:
     # Propagate path to symbolizer for ASan/MSan.
     llvm_config.with_system_environment(
         ['ASAN_SYMBOLIZER_PATH', 'MSAN_SYMBOLIZER_PATH'])
 
 # Check which debuggers are available:
 lldb_path = llvm_config.use_llvm_tool('lldb', search_env='LLDB')