Page MenuHomePhabricator

[Libomptarget] Run GPU offloading tests using the new driver
ClosedPublic

Authored by jhuber6 on Jan 31 2022, 11:43 AM.

Details

Summary

This patch adds a new target to the tests to run using the new driver as
the method for generating offloading code.

Depends on D116541

Diff Detail

Event Timeline

jhuber6 created this revision.Jan 31 2022, 11:43 AM
jhuber6 requested review of this revision.Jan 31 2022, 11:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 11:43 AM
jhuber6 updated this revision to Diff 404649.Jan 31 2022, 11:50 AM

Adding XFAIL to test.

JonChesterfield retitled this revision from [Libomptarget] Run GPU offloading tests using the new drvier to [Libomptarget] Run GPU offloading tests using the new driver.Jan 31 2022, 11:59 AM
JonChesterfield added inline comments.
openmp/libomptarget/test/lit.cfg
112

You need to generalise / replace this function to avoid passing nvptx64-newDriver or similar as the triple

jhuber6 updated this revision to Diff 404663.Jan 31 2022, 12:19 PM

Addressing triple and adding test for static linking.

jhuber6 updated this revision to Diff 404725.Jan 31 2022, 2:04 PM

Add AMDGPU

JonChesterfield accepted this revision.Jan 31 2022, 2:12 PM

Looks good. We can land this and revert with greater knowledge if the amdgpu buildbot fails on it.

openmp/libomptarget/CMakeLists.txt
40

Could drop the amdgcn-amd-amdhsa and nvptx64-nvidia-cuda lines in passing, I should have removed them previously. Or leave them and we'll remove the -newRTL ones instead of renaming them.

openmp/libomptarget/test/lit.cfg
119

LG. We should drop this newRTL thing at some point.

This revision is now accepted and ready to land.Jan 31 2022, 2:12 PM
jhuber6 added inline comments.Jan 31 2022, 2:13 PM
openmp/libomptarget/test/lit.cfg
119

Yeah, I'll soon make a patch that removes the old runtime.