Page MenuHomePhabricator

[OpenMP] Search for static libraries in offload linker tool
ClosedPublic

Authored by jhuber6 on Jan 5 2022, 10:27 AM.

Details

Summary

This patch adds support for searching through the linker library paths
to identify static libraries that may contain device code. If device
code is present it will be extracted. This should ideally fully support
static linking with OpenMP offloading.

Depends on D116627

Diff Detail

Event Timeline

jhuber6 created this revision.Jan 5 2022, 10:27 AM
jhuber6 requested review of this revision.Jan 5 2022, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2022, 10:27 AM
jdoerfert accepted this revision.Jan 31 2022, 9:46 AM

LG, one nit

clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
627

This seems to handle -Lfoo, what about -L bar? at least a todo would be good.

This revision is now accepted and ready to land.Jan 31 2022, 9:46 AM
jhuber6 added inline comments.Jan 31 2022, 10:01 AM
clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
627

These arguments come from clang, and are somewhat normalized by clang so they will always be in the form "-Lfoo" when they come from clang. I could add some checks for that if we expect the user to be calling this manually.

This revision was landed with ongoing or failed builds.Jan 31 2022, 8:12 PM
This revision was automatically updated to reflect the committed changes.