This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Stop reserving 36-bytes before kernel arguments for amdpal
ClosedPublic

Authored by arsenm on Jan 17 2022, 6:44 AM.

Details

Summary

This was inheriting the mesa behavior, and as far as I know nobody is
using opencl kernels with amdpal. The isMesaKernel check was
irrelevant because this property needs to be held for all functions.

Diff Detail

Event Timeline

arsenm created this revision.Jan 17 2022, 6:44 AM
arsenm requested review of this revision.Jan 17 2022, 6:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2022, 6:44 AM
Herald added a subscriber: wdng. · View Herald Transcript
sebastian-ne accepted this revision.Jan 20 2022, 4:15 AM

Under the assumption that opencl or hip on pal do not use this, it looks fine to me.

This revision is now accepted and ready to land.Jan 20 2022, 4:15 AM